Consistency helps :)

On Mon, Mar 20, 2017 at 12:16 PM, John Mazzitelli <mazz@redhat.com> wrote:
It was pointed out to me (which I forgot) that WildFly itself supports the syntax ${env.X} to denote environment variables.

Now, this Java Agent isn't based on WildFly and these ${x} tokens appear in the yaml file and not the standalone.xml so we technically do no have to be consistent with WildFly syntax, but I wonder if I should switch this anyway to use the ${env.X} syntax just to make it consistent for people that are familiar with WildFly syntax.

Let me know - this would be a trivial change but I would like to make another release quickly if this change is to be made.

--John Mazz

----- Original Message -----
> Thanks for the update ! And for releasing-early/releasing-often
>
> On Sat, Mar 18, 2017 at 3:22 PM, John Mazzitelli <mazz@redhat.com> wrote:
>
> > Just released Hawkular Java Agent 0.29.1.Final that contains a new feature.
> >
> > To support deploying Java Agent within containers (though this feature
> > isn't restricted to that use-case), you can configure many settings in the
> > Java Agent YAML config with ${x} expressions (similar to how HWFA can be
> > configured in standalone.xml).
> >
> > It supports getting values from system properties, environment variables,
> > with default values optionally defined. The following expressions are
> > supported - hopefully this is self-explanatory:
> >
> > ${some.system.property}
> >
> > ${some.system.property:a-default-value}
> >
> > ${ENV~SOME_ENV_VAR}
> >
> > ${ENV~SOME_ENV_VAR:a-default-value}
> >
> > Not all properties support expressions (most don't need them) but
> > properties that define things like hosts, ports, urls, passwords,
> > filepaths, do support expressions.
> >
> > If I missed any, or if you'd like a property to support expressions that
> > does not currently, write a HWKAGENT JIRA: https://issues.jboss.org/
> > projects/HWKAGENT
> >
> > _______________________________________________
> > hawkular-dev mailing list
> > hawkular-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hawkular-dev
> >
> >
> >
>
_______________________________________________
hawkular-dev mailing list
hawkular-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev