On 20 Mar 2015, at 08:19, Lukas Krejci <lkrejci@redhat.com> wrote:
I think the "metrics" should actually be dropped instead of "numeric”.
The only thing about ‘numeric’ is that it is not very specific. Numeric just means number — every metric is a number so its really not adding anything. Even availability data is numeric.
Metrics might not just be numeric. Right now we have simple numeric and availability. We will probably have events at in the future. We might also have multi-value numeric metrics, e.g., call time in RHQ. And I could also see multi-value metrics consisting of numeric and text data.
Hawk metrics will never deal with anything else than some kind of metric, so
way have it in the path? On the other hand having the type of the metric in
the path is IMHO more useful.
It is the context root of the metrics rest web app that should be called
"metrics", IMHO.
So the paths in metrics would look like:
/{tenantId}/numeric/data
/{tenantId}/availability/data
and the REST API user would reach those on the URLs like:
http://asdf.com/hawkular/metrics/tenant1/numeric/{id}/data
conversely, inventory could be reached on the same host like:
http://asdf.com/hawkular/inventory/tenant1/production/resources/{id}
On Friday, March 20, 2015 11:00:22 John Sanda wrote:
There has been some good discussion around availability lately. I want to
add one more to the mix, but hopefully this one is not as in-depth as some
of the other topics. Right in metrics we have endpoints like,
POST /metrics/numeric/data
GET /metrics/numeric/{id}/data
POST /metrics/availability/data
GET /metrics/availability/{id}/data
I would like to change these to,
POST /metrics/data
GET /metrics/{id}/data
POST /availability/data
GET /availability/{id}/data
I think the “metrics” prefix is awkward and unnecessary. I think that it is
intuitive enough that metrics on its own refers to numeric data. Thoughts?
- John
_______________________________________________
hawkular-dev mailing list
hawkular-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
_______________________________________________
hawkular-dev mailing list
hawkular-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
_______________________________________________hawkular-dev mailing listhawkular-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/hawkular-dev