On Thu, Nov 23, 2017 at 8:46 PM, Lucas Ponce <lponce@redhat.com> wrote:

On Thu, Nov 23, 2017 at 7:35 PM, Alissa Bonas <abonas@redhat.com> wrote:

Thomas, I believe Lucas means moving those files between miq repos, so the release process for them remains the same.

Lucas, correct me if I'm wrong, but you are talking about those files
https://github.com/ManageIQ/manageiq/tree/master/product/live_metrics

I don't think there would be any objections (the proposal makes sense to me ), the only thing I am wondering/concerned about whether that will work well. Because our repo is considered and packaged as a gem (while the main repo is a rails app), so I guess it would be mainly a question of *will it work or not*

Yes, it is just an implementation detail.

Today, we have a 1 to 1 mapping between middleware_server in MiQ and metrics that are supported in Hawkular.

This more or less worked fine until now.

So, as potentially we might have different servers with different metrics, this also impacts on this.

But I have been tested and I guess the current mechanism to re-join the manageiq reports gems is not prepared for the product/ folder.

(Tested locally doesn't work)

Anyway, it's not a problem, I can maintain files in the main repo, or change the folder if you know some folder we can use to place our config files, it is not a problem, just to change a path.

So I would rephrase my question, if I would like to add config files specific for the provider, where I can put them in the manageiq-providers-hawkular repo in order those are copied in the main manageiq repo when gem is used ? 

(If it it's technically possible)

I think it depends where in the product those files are expected to "land" in the deployment and where is the code that should use them.

Caina, can you please work with Lucas on this?

 

 

On Thu, Nov 23, 2017 at 6:55 PM, Thomas Heute <theute@redhat.com> wrote:

One reason for the remote config files is to be able to relatively quickly push an image to fix an issue, if moved to manageiq-providers-hawkular, one would have to wait until a new version of ManageIQ gets released.

Thomas

On Thu, Nov 23, 2017 at 5:35 PM, Lucas Ponce <lponce@redhat.com> wrote:

Hi,

In the context of tasks of HAWKULAR-1275 I think that moving those config files inside manageiq-providers-hawkular may make sense as probably I need to split them per type (EAP6 might have different metrics than EAP7, for example).

I guess it shouldn't be a problem as our provider is the only user for this.

Does anyone see any issue if I perform this change ?

Thanks,

Lucas

_______________________________________________
hawkular-dev mailing list
hawkular-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev

_______________________________________________
hawkular-dev mailing list
hawkular-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev