I've been testing this out for the past day, and this is fantastic.   I have it attached to Karaf pushing metrics to Hawkular and it looks like it's working very well.   I'm trying it on SpringBoot next, but if it works on Karaf, I'm not sure why it wouldn't work on SpringBoot.

Things I'd like to contribute back possibly if they sound interesting : 

- delay (the delay X seconds is useful, but I'd like to have a way of polling to see if the MBeans are registered yet, and then starting the agent)
- size of javaagent : it looks like the JAR is about 24MB, I might look into seeing if there's a way of slimming that down.    For our purposes, we're only really interested in JMX support, so I'm going to see if I can build a profile that filters out the DMR stuff and their dependencies for a smaller fat JAR
- optional log integration with Karaf?




On Thu, Mar 9, 2017 at 3:04 PM, John Mazzitelli <mazz@redhat.com> wrote:
> > I still need to see how well this supports the disabling/enabling of
> > metrics on the fly from the websocket commands (e.g. I will need to add the ability
> > to change the YAML config to persist the settings, that is not done yet -
> > the EAP-based agent got this support for free - its config changes go into
> > standalone.xml).
>
> Just checked - the cmdgw command to update collection intervals won't work
> because it is assuming the agent is always DMR-accessible which it no longer
> is. This won't be hard to refactor that command to get it to work, but for
> now, this will not work when running as javaagent - still works as normal
> with the subsystem agent.

This is fixed now. Updating collection intervals and enabling/disabling metrics should now work even when deployed at a javaagent.

At this point in time, I'm hard-pressed to think of a feature the WildFly Agent has that the javaagent does not (short of the obvious "there is no CLI" and "there is no installer" - but there is really nothing to install so that's moot). If anyone plays with this (especially with CFME on the front end) let me know what you find.

I'm sure I'm forgetting something, but right now, it looks like it is working really well. I just have to build in itests for it (right now, all the WildFly Agent itests still exist and pass, so I know I didn't break that).
_______________________________________________
hawkular-dev mailing list
hawkular-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev