Something that just hit me. With this we don't even need an installer anymore... (we just need to include a doc page for the parameters to pass)

Simplification FTW !

On Sun, Mar 12, 2017 at 12:09 AM, John Mazzitelli <mazz@redhat.com> wrote:
As for the question "Did you try deployments over this?" - I have been writing a bunch of itests. I basically copied the itests we already have and tweeked them to run against the javaagent. So far, so good. All of the tests pass in this PR with virtually no changes to the core engine (they pass on my box, who knows what travis is doing - sometimes they pass, sometimes they don't).

https://github.com/hawkular/hawkular-agent/pull/302

I need to create two more sets of tests before I can say it all works the same as the wildfly agent without breakage:

1) domain tests (I've got the standalone tests passing - including deployments - just have to test domain mode)
2) immutability tests (show that the agent won't try to change anything if its immutable)

Tests I'm building are here:

https://github.com/jmazzitelli/hawkular-agent/tree/refactor-core/hawkular-javaagent-itest-parent/hawkular-javaagent-all-itests

NOTE: the agents (both javaagent and wildfly agent) now support invoking JMX operations in both local and remote JMX servers in my branch - the old agent did not have this support.
_______________________________________________
hawkular-dev mailing list
hawkular-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev