"looking at the code which has a problem and fix it" sounds so simple :), it did sound simple, until i got to working on a bug with sql generation and had huge amount of time figuring out what went wrong, even now, after i found the bug, i don't know if fixing it requires major refactoring or is it something simpler then i'm missing.

yes, i know about the unitests, they scared me at first, when i first run them after the initial download and saw failures, but i guess i didn't read the results correctly because the hibernate-core project test went ok.

On Tue, Apr 14, 2009 at 6:51 PM, Max Rydahl Andersen <max.andersen@redhat.com> wrote:

i never thought hibernate was simple, my problem is that i don't see how anyone outside jboss personal can actually create fixes (patches or commits) without internal overview of hibernate. and jumping head first is actually what a new developer in jboss would need to do, even if he did had prior usage of hibernate. so either there  are white papers kept in jboss for their use only , or the information is pass down orally by a senior developer.
There are no internal secret jboss documents - all the information is public. Many people are creating patches to hibernate in various areas by simply reading the code that is having a problem and fix it - of course for more detailed hardcore bugs more info is needed, but no written documentation would help you there - you would still need to look at the code to learn it.

btw. I did not work for JBoss when I started contribute to Hibernate, and there are non-JBoss committers today too - the right to commit is earned by showing skill and drive; not by getting hired.


to give an example, we have a developer with a 7 year experience in java j2ee, working on an undocumented homegrown framework with no internal overview documentation, and only oral info passed from previous developer, and that's not nearly enough as fixes usually break something else.
Look at the unittests, if you break them you know you messed up - if they pass the chance of you having messed up is less ;)

/max
On Tue, Apr 14, 2009 at 3:30 PM, Chris Bredesen <cbredesen@redhat.com <mailto:cbredesen@redhat.com>> wrote:

   Some observations on this thread:

   1. You do not need m2eclipse.  /trunk and /Branch_3_3 both use
   Maven 2 and will build straight away with "mvn compile".

   2. You can generate Eclipse or IDEA project files from the command
   line in the standard Maven way (mvn eclipse:eclipse or mvn
   idea:idea) and then import the projects.  I understand that IDEA
   reads Maven metadata natively but I cannot speak to that.

   3. Only committers are allowed to ... commit.  This is what the
   svn.jboss.org <http://svn.jboss.org/> server is for.
   anonsvn.jboss.org <http://anonsvn.jboss.org/> is a replica with

   read-only privileges.  Use this for now.  You are free to open
   JIRA tickets and attach patch files which will be reviewed by
   Hibernate committers and possibly committed in a future release.

   4. Yes, Hibernate is complicated.  It is not a trivial project to
   jump into head-first.  So please understand that there are many
   ways to contribute:

    * Helping on the forums
    * Hanging around in IRC to participate/answer questions
    * Improving the wiki
    * Filing JIRA issues for bugs or attaching test cases that are
   required

   Happy Hibernating,

   Chris

   joy deep wrote:

       Thanks soo much , I was by the side of the ocean no idea about
       depth .
       Are only JBoss people allowed to make changes !!!


       Thanks and Regards
       Joydeep Bhattacharjee


       --- On *Tue, 14/4/09, Elhanan Maayan /<elh.mailgate@gmail.com
       <mailto:elh.mailgate@gmail.com>>/* wrote:


          From: Elhanan Maayan <elh.mailgate@gmail.com
       <mailto:elh.mailgate@gmail.com>>

          Subject: Re: [hibernate-dev] want to join hibernate development
          community
          To: "joy deep" <bha_joy@yahoo.co.in
       <mailto:bha_joy@yahoo.co.in>>

          Cc: "Peter Harrison" <peter.harrison@methodmaker.co.nz
       <mailto:peter.harrison@methodmaker.co.nz>>,        <mailto:hibernate-dev@lists.jboss.org>

          Date: Tuesday, 14 April, 2009, 6:38 PM

          i've started a small blog http://osventure.wordpress.com/
       about my
          experiences with open source, documenting my attempts.
              please note that you will need m2eclipse plugin to
       download the
          code, as the svn repo is not in eclipse project.
          you will then need to change your .settings.xml file for
       maven in
          ~/m2 direcotry  for jboss plugins
              also after you downloaded the code you will encounter
       huge amount of
          compiler errors  you will need to the following:
              1. run mvn install on the pom parent - to generate some
       antlr files
          that were not generated during the initial load
          2. change hibernate-core project compiler settings to :
             generated .class file compatibility to 1.4,       source
       compatibility : 1.4
          3. on hibernate-common-annotations project change the compiler
          error/warnings , turn the forbidden reference (access rules) to
          warning instead of error.
              good luck getting your feet, personally i feel somewhat
       drowning
          when i'm trying to figure out this bug :
       http://opensource.atlassian.com/projects/hibernate/browse/HHH-3856
              personally i have no idea how anyone outside jboss can
       even begin to
          start modify the code without some white papers or
       explanation on
          the internal structure of hibernate.
          On Tue, Apr 14, 2009 at 6:05 AM, joy deep
       <bha_joy@yahoo.co.in <mailto:bha_joy@yahoo.co.in>

       </mc/compose?to=bha_joy@yahoo.co.in
       <mailto:bha_joy@yahoo.co.in>>> wrote:

              Hi,
                  Is there any SVN repository from where I can
       download the
              source codes, and set up my project in eclipse .Can you
       also
              give the Bugzilla link for hibernate.I want to get my
       feet wet
              with the code soon . Thanks for replying.


              Thanks and Regards
              Joydeep Bhattacharjee


              --- On *Tue, 14/4/09, Peter Harrison
              /<peter.harrison@methodmaker.co.nz
       <mailto:peter.harrison@methodmaker.co.nz>

       </mc/compose?to=peter.harrison@methodmaker.co.nz
       <mailto:peter.harrison@methodmaker.co.nz>>>/* wrote:


                  From: Peter Harrison
       <peter.harrison@methodmaker.co.nz
       <mailto:peter.harrison@methodmaker.co.nz>

       </mc/compose?to=peter.harrison@methodmaker.co.nz
       <mailto:peter.harrison@methodmaker.co.nz>>>


                  Subject: Re: [hibernate-dev] want to join hibernate
                  development community
                  To: bha_joy@yahoo.co.in
       <mailto:bha_joy@yahoo.co.in>
       </mc/compose?to=bha_joy@yahoo.co.in <mailto:bha_joy@yahoo.co.in>>


                  Date: Tuesday, 14 April, 2009, 5:02 AM

                  The ideal way to get involved is to download the
       source and
                  get familiar with it first - if you have not
       already. I am
                  here because I made some modifications to hibernate
       for my
                  own project and want to contribute back. The best
       way to
                  start is to look at existing bug reports, write a
       patch or
                  two and attach them to the ticket. Of course, I'm in a
                  similar boat as you, in that I'm not an active
       committer
                  right now. I'm personally looking at issues which
       affect me
                  - aka I don't want to be committing code for things
       that I
                  am not having practical use for.

                  2009/4/12 <bha_joy@yahoo.co.in
       <mailto:bha_joy@yahoo.co.in>

       <http://mc/compose?to=bha_joy@yahoo.co.in>>


                      Hi All,

                            I am new to hibernate development
       community though
                      I have been using the the product for some time
       now , I
                      would like to be a part of this wonderful
       product how
                      can I get on with it .
                      Any help in this regard will be highly appreciated.




                    ------------------------------------------------------------------------
              Add more friends to your messenger and enjoy! Invite
       them now.
       <http://in.rd.yahoo.com/tagline_messenger_6/*http://messenger.yahoo.com/invite/>



              _______________________________________________
              hibernate-dev mailing list
       hibernate-dev@lists.jboss.org
       <mailto:hibernate-dev@lists.jboss.org>

       </mc/compose?to=hibernate-dev@lists.jboss.org
       <mailto:hibernate-dev@lists.jboss.org>>


       https://lists.jboss.org/mailman/listinfo/hibernate-dev



       ------------------------------------------------------------------------
       Get perfect Email ID for your Resume. Get before others grab.
       <http://in.rd.yahoo.com/tagline_dbid_9/*http://in.promos.yahoo.com/address>


       ------------------------------------------------------------------------



       _______________________________________________
       hibernate-dev mailing list
       hibernate-dev@lists.jboss.org
       <mailto:hibernate-dev@lists.jboss.org>

       https://lists.jboss.org/mailman/listinfo/hibernate-dev

   _______________________________________________
   hibernate-dev mailing list
   hibernate-dev@lists.jboss.org <mailto:hibernate-dev@lists.jboss.org>

   https://lists.jboss.org/mailman/listinfo/hibernate-dev


------------------------------------------------------------------------

_______________________________________________
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev