7:33 p.m.
Hello!
I just looked into the Hibernate Search source code and was wondering
why you are using hibernates criteria API instead of JPA Criteria API? I
haven't looked deeper but actually this is the reason why it can't be
used with other JPA implementations, or are there any other dependencies
to hibernate specifc code? From a performance perspective it is probably
a bad idea to use JPA Criteria API, but if no really special
dependencies to the hibernate core code are needed to make it working
why not adapting it to JPA?
I would like to help to make it usable with other JPA implementations(at
least if it is possible)!
--
Mit freundlichen Grüßen,
------------------------------------------------------------------------
*Christian Beikov*
8:03 p.m.
Hi Christian,
I think the main reason has been the lack of interest, and the additional
difficulties such an integration would bring in terms of proper
testing and maintenance.
There are some performance and efficiency tricks we can take
advantage of, but I don't remember of many on the top of my head; I
guess one might have to live with a slower MassIndexer but that's
likely not a showstopper as long as such a decision would be optional.
There are also historical reasons: Hibernate Search was created before
JPA2, hence no criteria API was available at the time, while Hibernate
already had it.
Since the dependencies to Hibernate ORM are now isolated in a
single module I think it might be an interesting exercise to do if
you're interested in it, but I'm not sure if we can commit to actually
maintain integration tests with other implementations and willing tot
chase other implementors for bugfixes and other needed changes.
I'm not saying "no way", but there must be some better reason to do it
than the coolness of showcasing that it can be done;
so it all boils down to the tricky question:
why would anyone want to use a different implementation ? :P
Cheers,
Sanne
On 29 May 2012 18:33, Christian Beikov <christian.beikov(a)gmail.com> wrote:
Hello!
I just looked into the Hibernate Search source code and was wondering
why you are using hibernates criteria API instead of JPA Criteria API? I
haven't looked deeper but actually this is the reason why it can't be
used with other JPA implementations, or are there any other dependencies
to hibernate specifc code? From a performance perspective it is probably
a bad idea to use JPA Criteria API, but if no really special
dependencies to the hibernate core code are needed to make it working
why not adapting it to JPA?
I would like to help to make it usable with other JPA implementations(at
least if it is possible)!
--
Mit freundlichen Grüßen,
------------------------------------------------------------------------
*Christian Beikov*
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
10:25 a.m.
Hello Christian,
As Sanne said, we won't do it ourselves but if someone is interested, we will be more
than happy to help and integrate the work.
With the work done in recent versions, most specific code is now isolated and it is
"just" a matter of creating a new module hibernate-orm-jpa under the same model
as hibernate-orm and work from there.
Emmanuel
On 29 mai 2012, at 20:03, Sanne Grinovero wrote:
Hi Christian,
I think the main reason has been the lack of interest, and the additional
difficulties such an integration would bring in terms of proper
testing and maintenance.
There are some performance and efficiency tricks we can take
advantage of, but I don't remember of many on the top of my head; I
guess one might have to live with a slower MassIndexer but that's
likely not a showstopper as long as such a decision would be optional.
There are also historical reasons: Hibernate Search was created before
JPA2, hence no criteria API was available at the time, while Hibernate
already had it.
Since the dependencies to Hibernate ORM are now isolated in a
single module I think it might be an interesting exercise to do if
you're interested in it, but I'm not sure if we can commit to actually
maintain integration tests with other implementations and willing tot
chase other implementors for bugfixes and other needed changes.
I'm not saying "no way", but there must be some better reason to do it
than the coolness of showcasing that it can be done;
so it all boils down to the tricky question:
why would anyone want to use a different implementation ? :P
Cheers,
Sanne
On 29 May 2012 18:33, Christian Beikov <christian.beikov(a)gmail.com> wrote:
> Hello!
>
> I just looked into the Hibernate Search source code and was wondering
> why you are using hibernates criteria API instead of JPA Criteria API? I
> haven't looked deeper but actually this is the reason why it can't be
> used with other JPA implementations, or are there any other dependencies
> to hibernate specifc code? From a performance perspective it is probably
> a bad idea to use JPA Criteria API, but if no really special
> dependencies to the hibernate core code are needed to make it working
> why not adapting it to JPA?
>
> I would like to help to make it usable with other JPA implementations(at
> least if it is possible)!
>
> --
> Mit freundlichen Grüßen,
> ------------------------------------------------------------------------
> *Christian Beikov*
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
4348
days inactive
4349
days old
2 comments
3 participants
participants (3)
-
Christian Beikov -
Emmanuel Bernard -
Sanne Grinovero