3:21 a.m.
All,
I just brought down a fresh copy of Branch_3_3, compiled and then ran
mvn eclipse:eclipse. The Eclipse projects were created mostly fine and
they all imported into Ganymede.
However, there's an issue with each module's dependency on
hibernate-core and hibernate-testing. The maven-eclipse-plugin creates
these as project dependencies instead of jar dependencies (probably
because they are all in the same group ID?), and it creates them with
the assumption that the project names are the same as the artifact ID.
This is in fact not the case.
Each module is broken because its reference to core and testing are
looking for hibernate-core and hibernate-testing respectively. Of
course this is a quick thing to fix but it means that the plugin doesn't
work properly.
Does anyone know if this is a bug? Is there some way to hint to Maven
that the dependencies should use a different directory than what the
artifact ID specifies?
Thanks,
Chris
1:13 p.m.
Chris Bredesen wrote:
All,
I just brought down a fresh copy of Branch_3_3, compiled and then ran
mvn eclipse:eclipse. The Eclipse projects were created mostly fine and
they all imported into Ganymede.
However, there's an issue with each module's dependency on
hibernate-core and hibernate-testing. The maven-eclipse-plugin creates
these as project dependencies instead of jar dependencies (probably
because they are all in the same group ID?),
No, it's because they are an exact version match and are all being
covered by a single invocation of "mvn eclipse:eclipse".
and it creates them with
the assumption that the project names are the same as the artifact ID.
This is in fact not the case.
It should be the case, and is for me. What is it for you, and have you
any idea why it's different?
Max.
3:17 p.m.
Max Bowsher wrote:
Hi Max.
Chris Bredesen wrote:
> and it creates them with
> the assumption that the project names are the same as the artifact ID.
> This is in fact not the case.
It should be the case, and is for me. What is it for you, and have you
any idea why it's different?
The project dependency in cache-ehcache, for example, is created as
depending on 'hibernate-core' and 'hibernate-testing'. The physical
directories that these projects are located in are 'core' and 'testing'
respectively. When I remove the errant project deps and open the dialog
to re-add them, I'm given 'core' and 'testing' as possibilities and
those work fine.
No I sure don't know why they're different, hence this email :)
I don't know why maven would assume a project is named after its
directory and not its artifactId. I can tell you this was not a problem
in the earlier days when 3.3 was trunk. I wonder what changed?
Have you built recently? I'm using Maven 2.0.8-SNAPSHOT...will try with
2.0.9.
-Chris
4:09 p.m.
Chris Bredesen wrote:
Max Bowsher wrote:
> Chris Bredesen wrote:
>> and it creates them with
>> the assumption that the project names are the same as the artifact ID.
>> This is in fact not the case.
>
> It should be the case, and is for me. What is it for you, and have you
> any idea why it's different?
The project dependency in cache-ehcache, for example, is created as
depending on 'hibernate-core' and 'hibernate-testing'. The physical
directories that these projects are located in are 'core' and 'testing'
respectively. When I remove the errant project deps and open the dialog
to re-add them, I'm given 'core' and 'testing' as possibilities and
those work fine.
No I sure don't know why they're different, hence this email :)
I don't know why maven would assume a project is named after its
directory and not its artifactId. I can tell you this was not a problem
in the earlier days when 3.3 was trunk. I wonder what changed?
The maven-eclipse-plugin has always assumed that the eclipse project
name is equal to the artifactId (unless you configure it otherwise) -
this isn't really an assumption, since this is the project name that it
writes to the .project file.
There does exist a corner case however - once you import a project into
Eclipse, Eclipse no longer cares about the name value in the on-disk
.project file. I suppose you had the relevant directories added to
Eclipse using manually created rather than plugin-generated projects.
If you delete the projects from the Eclipse workspace and re-import what
the plugin generates, it should correctly name them "hibernate-core" and
"hibernate-testing".
Have you built recently?
Just now.
I'm using Maven 2.0.8-SNAPSHOT...will try with
2.0.9.
Why would you be using such an old snapshot? Or a snapshot at all? Not
that I think it's the problem in this case.
Max.
4:15 p.m.
1) Are you using the *final* Ganymede ? the RC1 of Ganymede had a broken
understanding of project names vs. directory names.
2) That m2eclipse actually resolves dependencies to project dependencies
insteead of jar dependencies is a *Good thing* (e.g. change something in
hibernate core and you dont have to wait for maven to complete it build to
see the changes, same goes for refactoring etc).
But if you really want it I do believe m2eclipse has an option for not
making proper project dependencies but just do jar in repository
dependency.
-max
Max Bowsher wrote:
Hi Max.
> Chris Bredesen wrote:
>> and it creates them with
>> the assumption that the project names are the same as the artifact ID.
>> This is in fact not the case.
> It should be the case, and is for me. What is it for you, and have you
> any idea why it's different?
The project dependency in cache-ehcache, for example, is created as
depending on 'hibernate-core' and 'hibernate-testing'. The physical
directories that these projects are located in are 'core' and 'testing'
respectively. When I remove the errant project deps and open the dialog
to re-add them, I'm given 'core' and 'testing' as possibilities and
those work fine.
No I sure don't know why they're different, hence this email :)
I don't know why maven would assume a project is named after its
directory and not its artifactId. I can tell you this was not a problem
in the earlier days when 3.3 was trunk. I wonder what changed?
Have you built recently? I'm using Maven 2.0.8-SNAPSHOT...will try with
2.0.9.
-Chris
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
--
-max
4:31 p.m.
Max Rydahl Andersen wrote:
1) Are you using the *final* Ganymede ? the RC1 of Ganymede had a
broken
understanding of project names vs. directory names.
Yep. No mention of RC1 anywhere.
Version: 3.4.0
Build id: I20080617-2000
2) That m2eclipse actually resolves dependencies to project
dependencies
insteead of jar dependencies is a *Good thing* (e.g. change something in
hibernate core and you dont have to wait for maven to complete it build
to see the changes, same goes for refactoring etc).
Oh I totally agree. I wish it would do it correctly :) But it seems I
have something else going on so I'll get to the bottom of it.
-CB
4:33 p.m.
Max Bowsher wrote:
There does exist a corner case however - once you import a project
into
Eclipse, Eclipse no longer cares about the name value in the on-disk
.project file. I suppose you had the relevant directories added to
Eclipse using manually created rather than plugin-generated projects.
Hmm. Here's what I did:
svn co ..../Branch_3_3
cd Branch_3_3
mvn install
mvn eclipse:eclipse
Then import into Eclipse from Branch_3_3 as workspace location.
Will try it again from scratch, maybe I missed something.
Thanks Max (and Max).
-CB
7:09 p.m.
Chris Bredesen wrote:
Max Rydahl Andersen wrote:
> 1) Are you using the *final* Ganymede ? the RC1 of Ganymede had a
> broken understanding of project names vs. directory names.
Yep. No mention of RC1 anywhere.
Version: 3.4.0
Build id: I20080617-2000
> 2) That m2eclipse actually resolves dependencies to project
> dependencies insteead of jar dependencies is a *Good thing* (e.g.
> change something in hibernate core and you dont have to wait for maven
> to complete it build to see the changes, same goes for refactoring etc).
Oh I totally agree. I wish it would do it correctly :) But it seems I
have something else going on so I'll get to the bottom of it.
It turns out that this happens when I try to use the checked out
directory as the Eclipse project base. So if I open Branch_3_3 as an
empty workspace and then import the maven projects, it uses 'core' for
the project name. If I create something like Branch_3_3_workspace, and
check out Branch_3_3 *inside* that, it works as expected.
Not sure if this is a bug or not, but *sigh*.
-CB
5722
days inactive
5722
days old
7 comments
3 participants
participants (3)
-
Chris Bredesen -
Max Bowsher -
Max Rydahl Andersen