Jeremy Carnus you have some code styles configuration files for IDEA and Eclipse there: https://github.com/hibernate/hibernate-ide-codestyles . You also need to include our usual header if you create a new file for your test.

Apart from that, I think it should be a very simple fix e.g. in the InPredicate taking the collection of values, you should check if the value is an Expression and then simply add it to the list instead of wrapping it in a LiteralExpression and it might work just with this change.

Apart from that, you need to include the test in our test suite, probably in the org.hibernate.jpa.test.criteria package.

I'm working with Eclipse and couldn't get ORM to build in Eclipse and run the test in the IDE, so what I do is:

cd hibernate-core
../gradlew test --tests=my.package.MyTest

to only run the test.

Once your test is working, you can run the full test suite to validate everything is OK with ./gradlew check at the root of your repo. Note that it will take some time .

That's definitely a nice issue to start contributing, just tell us if you plan to look at it in the next few days .

Thanks!