| The SequenceNextValueGenerationTest verifies that the total number of increments is compatible with the expectations, but should also verify that the generated sequence numbers are strictly unique. The Hot Rod dialect has a similar test SequenceAtomicIncrementTest which does verify uniqueness, but is tied to the specific Hot Rod dialect implementation. We could make a unified test taking the better aspects of both tests, and move that to the core module, to be extended by dialect specific initializations. |