Hi, I’m just testing hibernate 6 because I’m planning the migration, but I found some errors related to the use of entity graphs, this case was working with hibernate 5.x and I’m reporting it because I didn’t find if non compatible changes were introduced.

When I create a subgraph on an attribute with the ON clause, the SQL join is duplicated, in the next example the table orderPosition is duplicated.

   selectdistinct c1_0.id,
        c1_0.orderDate,
        o2_0.customerOrder,
        o2_0.id,
        o2_0.amount,
        o2_0.deleted,
        p1_0.id,
        p1_0.productName,
        s1_0.id,
        s1_0.city 
    from
        customerOrder c1_0 
    left join
        orderPosition o1_0 
            on c1_0.id=o1_0.customerOrder 
            and o1_0.deleted=false 
    left join
        orderPosition o2_0 
            on c1_0.id=o2_0.customerOrder 
    left join
        product p1_0 
            on p1_0.id=o2_0.product 
    left join
        address s1_0 
            on s1_0.id=c1_0.shippingAddress_id

I modified the class EntityGraphUsingFetchGraphTest.java to create a new test case to show you the problem:

• https://github.com/wsaca/hibernate-orm/blob/error-entity-graph-on-clause/hibernate-core/src/test/java/org/hibernate/orm/test/entitygraph/EntityGraphUsingFetchGraphTest.java#L266

I also have an issue where Criteria API ignores a custom Converter that I’m using to convert VARCHAR to Boolean using spanish characters. With JPQL the same converter is working. Should I create a new issue?