Do I need to make additional changes to the PRs? How are the IDs assigned?
Yes, that’s the crux 🙂 At the moment I manually go through all of them and look. The intention was to leverage https://docs.jboss.org/hibernate/orm/6.0/logging/logging.html which is generated on release. That report is generated using Jandex, which at the time I wrote all of that only had the ability to read annotations with runtime retention. And of course, JBoss Logging annotations are class retention iirc - not runtime at any rate. I know Ladislav planned to change that so that Jandex could read all retentions. He may have already done that, I need to check. At that point, we’d see the registrations in that report. But at the moment you have to look through the code. I was planning on doing that as I feel bad asking someone else to do it - it is a pita 😉 |