Message Title

Vlad Mihalcea created an issue

Issue Type:	Improvement
Affects Versions:	5.4.10
Assignee:	Unassigned
Components:	hibernate-core
Created:	07/Feb/2020 05:37 AM
Priority:	Major
Reporter:	Vlad Mihalcea

The EntityManagerFactoryBuilderImpl calls the buildBootstrapServiceRegistry like this:

 
                                                                // Build the boot-strap service registry, which mainly handles class loader interactions
final BootstrapServiceRegistry bsr = buildBootstrapServiceRegistry( integrationSettings, providedClassLoader, providedClassLoaderService);

// merge configuration sources and build the "standard" service registry
final StandardServiceRegistryBuilder ssrBuilder = StandardServiceRegistryBuilder.forJpa( bsr );

final MergedSettings mergedSettings = mergeSettings( persistenceUnit, integrationSettings, ssrBuilder );

It would be better if we did it like this:

 
                                                                final MergedSettings mergedSettings = mergeSettings( persistenceUnit, integrationSettings, ssrBuilder );

// Build the boot-strap service registry, which mainly handles class loader interactions
final BootstrapServiceRegistry bsr = buildBootstrapServiceRegistry( mergedSettings, providedClassLoader, providedClassLoaderService);

// merge configuration sources and build the "standard" service registry
final StandardServiceRegistryBuilder ssrBuilder = StandardServiceRegistryBuilder.forJpa( bsr );

This way, we can use the PersistenceUnit properties as well, when scanning for an IntegratorProvider.

Currently, passing the IntegratorProvider works only in Spring, not in Java EE applications using the persistence.xml configuration file.

Add Comment

Get Jira notifications on your phone! Download the Jira Cloud app for Android or iOS

This message was sent by Atlassian Jira