Message Title

Archie Cobbs created an issue

HHH-12068

Issue Type:	Bug
Affects Versions:	5.2.11
Assignee:	Unassigned
Components:	hibernate-jpamodelgen
Created:	27/Oct/2017 14:48 PM
Priority:	Minor
Reporter:	Archie Cobbs

See METAGEN-50 Closed for background. That bug added support for adding

 
                                                                @SuppressWarnings("all")

to generated metamodel source files.

Unfortunately, @SuppressWarnings("all") is an Eclipe-ism and not guaranteed to actually do anything.

In fact the JDK compiler ignores it:

 
                                                                $ cat xx.java 
@SuppressWarnings("all") class xx { static ThreadLocal x; }
$ javac -Xlint:all xx.java
xx.java:1: warning: [rawtypes] found raw type: ThreadLocal
@SuppressWarnings("all") class xx { static ThreadLocal x; }
                                           ^
  missing type arguments for generic class ThreadLocal<T>
  where T is a type-variable:
    T extends Object declared in class ThreadLocal
1 warning
 
                                                            

Instead of suppressing "all" which is technically meaningless, it should suppress (at least) "rawtypes" and probably "unchecked" too.

Add Comment

Get Jira notifications on your phone! Download the Jira Cloud app for Android or iOS

This message was sent by Atlassian Jira