[hibernate-issues] [Hibernate-JIRA] Issue Comment Edited: (HSEARCH-753) fullTextQuery.getResultList().size() != fullTextQuery.getResultSize() when using criteria
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753?pag...
]
Emmanuel Bernard edited comment on HSEARCH-753 at 6/20/11 4:12 AM:
-------------------------------------------------------------------
The major risk was that we could return null elements in a the getResultList() instead of
properly filtering results. If that has truly changed then we can:
* adjust the documentation still no recommending such use but letting people know that it
works ok except for getResultSize()
* we might even think about:
** raising a exception when people use getResultSize on a criteria with where clauses AND
firstResult / maxResult is used
** return getResultList().size() if firstResult / maxResult is not used (that is
problematic though as it's way more costly than a Lucene size => probably not the
right thing to do
was (Author: emmanuel):
The major risk was that we could return null elements in a the getResultList() instead
of properly filtering results. If that has truly changed then we can:
* adjust the documentation still no recommending such use but letting people know that it
works ok except for getResultSize()
* we might even think about raising a exception when people use getResultSize on a
criteria with where clauses
fullTextQuery.getResultList().size() != fullTextQuery.getResultSize()
when using criteria
-----------------------------------------------------------------------------------------
Key: HSEARCH-753
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-753
Project: Hibernate Search
Issue Type: Bug
Components: query
Affects Versions: 3.4.0.Final
Environment: hibernate 3.6.4.Final / postgresSQL
Reporter: Mathieu Perez
Fix For: 4.0.0.Alpha1
Attachments: ResultSizeOnCriteria.java, Tractor.java
1) My indexes are up-to-date and optimised
2) I'm aware about this part of documentation: "Like Google, the number of
results is approximative if the index is not fully up-to-date with the database
(asynchronous cluster for example)."
3) Two types of queries:
3.1) Query with "keyword" (or
"below"/"above"/"fromTo")
{code}
QueryBuilder qb = fullTextSession.getSearchFactory().buildQueryBuilder().forEntity(
Book.class ).get();
org.apache.lucene.search.Query query = qb
.keyword()
.onFields("title", "subtitle", "authors.name",
"publicationDate")
.matching("Java rocks!");
.createQuery();
{code}
In this case, I don't meet any problem:
query.getResultSize() == query.getResultList().size()
3.2) Query with criteria
{code}
Criteria criteria = s.createCriteria( Book.class
).createCriteria('isbn').add(Restrictions.like('XXXXXX'))
Query q = s.createFullTextQuery( luceneQuery ).setCriteriaQuery( criteria );
{code}
In this case, the result is different:
{code}
query.getResultSize() != query.getResultList().size()
{code}
Actually, query.getResultSize() exactly returns the number of Book contained in my
Book's table. (select count(*) from Book;) without taking in consideration my
criteria.
I don't known if it's really a bug either it's the expected behaviour.
When inspecting the org.hibernate.search.query.engine.impl.HSQueryImpl java class, I
realized that
{code}
QueryHits queryHits = getQueryHits( searcher, 0 ) :
{code}
- 3.1) Takes in charge my keyword
- 3.2) Doesn't seem to use my criteria
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira