Message Title

Yoann Rodière updated an issue

Thanks for the report. Indeed, the Lucene integration only logs the query before full-text filters are applied.

It may have been intended like that (though I doubt it). At the very least it's inconsistent with the Elasticsearch integration where we log the full query, filters included.

We should have a look and fix that in Search 6. Let's also consider backporting a fix to 5.11 when it's done in 6.

Change By:	Yoann Rodière
Component/s:	backend-lucene
Fix Version/s:	6.0.0.Beta-backlog
Fix Version/s:	5.11.1.Final
Summary:	Better Include enabled full-text filters when logging of executed full-text queries that utilize enableFullTextFilter

Hibernate Search filters that utilize enableFullTextFilter are not logged.

Currently Instead , the we only logs I could find to my executing log the query *before* full text filters are related applied to the org.apache.lucene.search.Query instance and not the org.hibernate.search.jpa.FullTextQuery instance. For example it :

{code:java|title=LazyQueryState.java}
public void search(final QueryFilters filters, final Collector collector) throws IOException {
  validateQuery();
  QUERY_LOG.executingLuceneQuery( userQuery );
  searcher.search( filters.filterOrPassthrough( rewrittenQuery() ), collector );
}
{code}

Which provides results in this, ignoring the only query related logging I have thus far found. full-text filter(s):
{code}
(LazyQueryState:99) - HSEARCH000274: Executing Lucene query '+ConstantScore(title:egg^5.0 summary:egg^2.0)'
{code}

h3.  Suggested Solution

Ideally, LazyQueryState query could be updated to provide a more complete solution for logging.  Maybe output that could be plugged directly into Luke would be the best?

h3.  Workaround

My quick and dirty workaround is provided below.
{code:java}
private String getQueryExplanationText(org.hibernate.search.jpa.FullTextQuery fullTextQuery) {

  StringBuffer sb = new StringBuffer();
  String newLine = System.getProperty("line.separator");

  fullTextQuery.setProjection(FullTextQuery.DOCUMENT_ID,
      FullTextQuery.EXPLANATION,
      FullTextQuery.THIS);

  @SuppressWarnings("unchecked")
  List<Object[]> results = fullTextQuery.getResultList();
  for (Object[] result : results) {
    Explanation e = (Explanation) result[1];
    sb.append(e.toString());
    sb.append(newLine);
  }

  fullTextQuery.setProjection();

  try
  {
    FullTextQueryImpl fullTextQueryImpl = (org.hibernate.search.query.hibernate.impl.FullTextQueryImpl)fullTextQuery;

    Field hSearchQueryField = fullTextQueryImpl.getClass().getDeclaredField("hSearchQuery");
    hSearchQueryField.setAccessible(true);
    LuceneHSQuery luceneHSQuery = (org.hibernate.search.query.engine.impl.LuceneHSQuery)hSearchQueryField.get(fullTextQueryImpl);

    Method luceneHSQueryCreateFiltersMethod = luceneHSQuery.getClass().getDeclaredMethod("createFilters");
    luceneHSQueryCreateFiltersMethod.setAccessible(true);
    QueryFilters queryFilters = (org.hibernate.search.query.engine.impl.QueryFilters)luceneHSQueryCreateFiltersMethod.invoke(luceneHSQuery);

    sb.append(queryFilters.getFilterQueries().toString());
    sb.append(newLine);

  }catch (Exception e) {
    LOGGER.error("Failed to get Query Explanation Text", e);
  }

  return sb.toString();
}
{code}

Add Comment

Get Jira notifications on your phone! Download the Jira Cloud app for Android or iOS

This message was sent by Atlassian Jira