Xavier Dury edited a comment on Improvement HSEARCH-1273

Hi,

Indeed the usage of Point|Coordinates is not clear: as stated in the doc, my entities can implement Coordinates so it is part of the public API and is normally safe to use where I want/need.

Point is indeed in a impl package but then why is it used in FullTextQuery.setSpatialParameters(Point, String)? Shouldn't it be FullText.setSpatialParameters(Coordinates, String)? If the usage of Point is removed from the public API, then I won't use it anymore.

By the way, wouldn't it be better to have something like SpatialConstants.COORDINATES_DEFAULT_FIELD instead of AbstractDocumentBuilder.COORDINATES_DEFAULT_FIELD? If a constant for the default field name is available in a public (non-impl) location, then I wouldn't need the new methods which don't take the field name.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira