|
Hi Steve,
The first set of checkStyle were related to CR/LF, when I converted them to Windows format it worked (that was 4 files in hibernate-c3p0 project).
However, when I fixed them, the build went on to the next project (hibernate-core) and generated a slue of errors, and this one, for example, should be caught on your system.....
-<file name="C:\development\hibernate-orm\hibernate-core\src\main\java\org\hibernate\CacheMode.java"> <error source="com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck" message="File does not end with a newline." severity="error" line="0"/> <error source="com.puppycrawl.tools.checkstyle.checks.whitespace.ParenPadCheck" message="'(' is not followed by whitespace." severity="warning" line="88" column="71"/> </file>
Note the error in the last line. If you go out to the Master, you will see the following, that line 88 does have a whitespace error..... .toUpperCase*(L*oc
CacheMode.java
return CacheMode.valueOf( setting.toUpperCase(Locale.ROOT) );
So, not only do I have the CR/LF issue with every file, there are other errors that are not detected on the CI servers
Sorry, but I am definately going to skip the checkStyle, as it is erroneous on Windows (If I re-format every file, it will probably break your checkStyle).
Jeff
|