| Hi Yoann,
because of Java license changes I have to update a closed source product to java 11.
Trying to make myself familar with netbeans10 bulk update refactoring feature I tested some of the dependencies I use in this closed source project.
There are some really cool refactoring features added to netbeans10. I learned about that from a twitter comment of James Gosling
https://twitter.com/errcraft/status/1078729057632583680 https://netbeans.org/kb/docs/java/editor-inspect-transform.html One of the dependencies I looked at is the latest production release of hibernate search.
At one point I decided that it could be interesting to share my experience or better some results with the maintainer and created the pull request
https://github.com/hibernate/hibernate-search/pull/1952 I wasn't aware that hibernate 5.11 is not any longer in focus. Sorry for that. I completely understand your arguments. Don't worry.
You suggested to create an issue about that before creating a pull request again.
I think it could be that for hibernate-search master (6.0) there are only few changes suggested by netbeans - at least that is the result of a short test. However it is up to you to decide what you want.
Some refactorings of course make the code incompatible with java 7 so that java 8 is required.
Instead of putting everything in one pull request for easier review it would be useful to use one pull request per refactoring even if you can get rid of unwanted commits using "git reset -p HEAD^" followed by "git commit --amend" anyway.
Of course it makes more sense that all this is done by someone of the hibernate-search development himself. Btw. I tried to do similar changes on hibernate-orm but today it looks like developing on hibernate-orm seems to be a nightmare if you are not using idea. |
