I see there is a problem here - I had missed the fact that generic generators are a Hibernate rather than a JPA concept and hence can't be included in a mapping ORM document if it is to comply with the orm.xsd. So I can either carry on with my fix on the pragmatic basis that it works but any mappings documents which use it won't comply with the JPA schema, or I could give up. Any thoughts anyone?

thanks

Richard