[~ctomc] & [~steve]:
Unless I'm missing something, I think the PR is incomplete. Only the ServiceBindings within StandardServiceRegistryImpl (AbstractServiceRegistryImpl) will be stopped. But ClassLoaderServiceImpl is in the parent registry (BootstrapServiceRegistryImpl). Having AbstractServiceRegistryImpl#destroy() call parent#destroy(), then wiring in cleanup there, should do it.
There's another gap where AbstractServiceRegistryImpl#createServiceBinding wasn't adding the binding to #serviceBindingList, used in destroy.
Am I missing anything?
|