| Hi. I'm trying be a new contributor. And get this task.
I changed MappingException message to:
String.format("Association %s for table %s references unmapped class: %s",
oneToMany.getReferencedEntityName(), oneToMany.getTable().getName(), assocClass).
and wrote unit test for it. But I find:
1. String assocClass = oneToMany.getReferencedEntityName();
And every time oneToMany.getReferencedEntityName() and assocClass will return equals value.
Is it corect for our exception message or need to change oneToMany.getReferencedEntityName() to other method;
2. There is a part of dead code:
if ( buildingContext == null ) { throw new AssertionFailure( "CollectionSecondPass for oneToMany should not be called with null mappings" ); } |