|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
At the very least, this fix is incomplete or not done right. Your fix weeds out the collection persisters based on whether the reference has an associated restriction (though completely misses checking sub-criterias); but you only do it while counting the collection persisters. Instead this should have been done in the walking. What happens atm is that the collection itself is weeded out, but if that collection is an association (one-to-many or many-to-many), the associated entity persister is not weeded out. This is
As for your argument, I will say that what I could see long term is for the fix to weed out collections from the join fetch list when (1) the join fetch comes from mapping and (2) the fetched association (or one of its sub-criterias) has a restriction.