This is more to be sure we don't forget discussing it with Yoann when he's back.
2 remarks: - apparently, at least with the ES 5 test case, the README.md is not accurate anymore as we need to use {{runforked}} instead of {{run}} to start the ES cluster . And using {{runforked}}, the ES instance is stopped when the JVM stops. We need to use the {{setAwait}} configuration knob to have something similar to what we had before with {{run}} - I could have fixed that but I'm wondering if we shouldn't have READMEs in every subdirectory instead so that we can point the user directly to the right one directly (Lucene or ES depending on what he's using). Currently, if I point the user to the Lucene subdirectory, he's a bit lost. I would keep the global one. - Wondering if it has value to keep the ES 2 test case now? |
|