Certain, long-awaited, changes are there in the current system that could be done as an improvement for {{wip/v6.0}}
Since all the following changes are method-level changes that are either public or protected, these could already being used for existing clients. Therefore, it is done as an improvement for wip/6.0, and not for the current (minor) versions.
So here is what needs to be done:
*1. Refactor StatelessSessionImpl for unused method parameter*
StatelessSessionImpl has a public method {{afterOperation(boolean success)}}
The method parameter {{success}} was used and passed as a parameter in afterNonTransactionalQuery().
Since the change was done long time back, the success variable is not being used now, and being passed by its caller in the same class now. In order to avoid that, a refactor can be done.
*2. TODO: Remove duplicate method from Constraint*
Constaint.java currently has two duplicate methods. 1. getColumnIterator()2. columnIterator()
Both the methods return the same value i.e. column.iterator().
One of them needs to be removed in order to reduce and clean the duplication.
* 3 2 . TODO: Change method name for getXmlFiles in BaseCoreFunctionalTestCase*
Currently, in BaseCoreFunctionalTestCase a method named getXmlFiles()has a TODO placed that suggests the method name to be changed to getOrmXmlFiles().
Since the method has a protected scope, there is a possibility it is being used by other clients. Hence, changing the method name in minor versions might break the code for clients.
Although, this long-awaited change can be done as an improvement in wip/v6.0 |
|
