I don't think the pull request as is really acceptable. As you already mentioned, your pull request breaks the contract for org.hibernate.type.descriptor.sql.BasicExtractor.

I will revisit this when I review Jiras related to attribute converters.