We have two sets of annotations for @SkipForDialect / @RequireDialectFeature / etc., in different packages: one that work with JUnit 4 and one that works with Junit 5. It can lead to confusion when using the JUnit 4 annotation on a JUnit 5 test, because the annotation will get ignored and the reason won’t be immediately obvious. We should deprecate the JUnit 4 annotations to at least give a hint that something odd is being used, and eventually (in a future major version) we should probably remove them. See https://hibernate.zulipchat.com/#narrow/stream/132094-hibernate-orm-dev/topic/Dialect.20checks.20in.20hibernate-testing |