|
Thanks for the pull request Nick.
Personally I think it is a mis-characterization that this was "far from complete" and that the work here was alot. Essentially what I missed that you fixed was building the JavaTypeDescriptor based on the AttributeConverter's "databaseColumnType" rather that its entityAttributeType. So really it was a one-line fix. The additional change you made in JavaTypeDescriptorRegistry is really a different (though certainly related) discussion.
As for the incredulity over this "taking so long", please realize that this is an Open Source project. I won't bore you with all the boring "excuses". Bottom line, if you have a "vested interest" in a change, you contribute that change (as you eventually did). All the "5 months" of complaining got you, was, well, 5 months of complaining. Then you sat down and contributed and helped fix it.
|