Message Title

Guillaume Husta created an issue

Issue Type:	Improvement
Affects Versions:	5.2.3.Final, 5.1.4.Final, 5.0.6.Final
Assignee:	Unassigned
Components:	reverse-engineer
Created:	11/Jul/2017 16:26 PM
Priority:	Minor
Reporter:	Guillaume Husta

When generating pojos with reverse engineering, it would be better to generate annotations for an id with a sequence in a correct order, and with line feeds.

Currently it looks like :

 
                                                                    @SequenceGenerator(name="test.domain.ActorIdGenerator", sequenceName="actor_actor_id_seq")@Id @GeneratedValue(strategy=SEQUENCE, generator="test.domain.ActorIdGenerator")    
    @Column(name="actor_id", unique=true, nullable=false)
    public Integer getActorId() {
        return this.actorId;
    }

It would be better to have :

 
                                                                    @Id
    @GeneratedValue(strategy = SEQUENCE, generator = "test.domain.ActorIdGenerator")
    @SequenceGenerator(name = "test.domain.ActorIdGenerator", sequenceName = "actor_actor_id_seq")
    @Column(name = "actor_id", unique = true, nullable = false)
    public Integer getActorId()
 
                                                            

IMO it needs to be fixed around https://github.com/hibernate/hibernate-tools/blob/5.2/src/java/org/hibernate/tool/hbm2x/pojo/EntityPOJOClass.java#L245

Add Comment

Get JIRA notifications on your phone! Download the JIRA Cloud app here.

This message was sent by Atlassian JIRA