Message Title

Vlad Mihalcea created an issue

Issue Type:	Bug
Affects Versions:	5.1.0
Assignee:	Vlad Mihalcea
Components:	documentation, hibernate-core
Created:	30/Mar/2016 22:46 PM
Fix Versions:	5.1.1
Priority:	Minor
Reporter:	Vlad Mihalcea

1. The GLOBALLY_QUOTED_IDENTIFIERS_SKIP_COLUMN_DEFINITIONS JavaDoc says

 
                                                                JPA states that column-definitions are subject to global quoting, so by
default this setting is {@code false} for JPA compliance. Set to {@code
true} to avoid column-definitions

While in the code we do the contrary:

 
                                                                private boolean
globalQuotingSkippedForColumnDefinitions(ConfigurationService cfgService) {
    return cfgService.getSetting(

AvailableSettings.GLOBALLY_QUOTED_IDENTIFIERS_SKIP_COLUMN_DEFINITIONS,
        StandardConverters.BOOLEAN,
        // default is true for JPA compliance - DO NOT CHANGE!
        true
    );
  }
 
                                                            

According to Steve Ebersole suggestions:

 
                                                                The code is wrong in the GLOBALLY_QUOTED_IDENTIFIERS_SKIP_COLUMN_DEFINITIONS case; the java doc is correct.  By default, we should not be skipping columnDefinitions while applying global-quoting to be sec compliant.

2. The KEYWORD_AUTO_QUOTING_ENABLED JavaDoc comments says:

 
                                                                /**
* Specifies whether to automatically quote any names that are deemed
keywords.  Auto-quoting
* is enabled by default.  Set to false to disable.
*/
String KEYWORD_AUTO_QUOTING_ENABLED = "hibernate.auto_quote_keyword";
 
                                                            

This one is said to be enabled by default, but if it's missing:

 
                                                                private static boolean autoKeywordQuoting(ConfigurationService cfgService) {
    return cfgService.getSetting(
        AvailableSettings.KEYWORD_AUTO_QUOTING_ENABLED,
        StandardConverters.BOOLEAN,
        false
    );
  }
 
                                                            

According to Steve Ebersole suggestions:

 
                                                                In the second case, it's the opposite... the Javadoc is wrong.  Keyword-quoting should be disabled by default.  Initially, I had this enabled by default, but it caused problems (I forget the details).  I just forgot to update the Javadoc when I switched.

Add Comment

This message was sent by Atlassian JIRA