Sanne Grinovero, what exactly would be the advantage of making the mass indexer factory a service?
It seems not to be used within Hibernate Search, which would be a motivating factor to me, as it then all using code could access it easily from the registry. Is it about re-using the same factory instance for several createIndexer() calls? That could also be achieved by just holding it as a member in FullTextSessionImpl, right?
I think the property will still be needed so we can set our custom implementation for OGM. How it then is cached internally within HSEARCH is independent from that I think.
|