|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
This is old and proven code which isn't needing a refactoring at this time, in fact we have large parts to rewrite for Lucene4 but I'd hope at least this infrastructure would stay stable.
Also I'm not convinced this is not a Visitor: look at the pattern, not the methods names: I'm not aware of a rule that says the Visitor needs a "visit" named method, in fact you can have multiple methods to take advantage of it.
Call it as you like, it's a double dispatch.. I'll try to refresh my patterns naming skills
We can discuss changing names or clarify javadocs if you really want to but I'm negative on creating objects on this hot path, can your context idea be reformulated to be static?