|
AFAICT everything in this issue has been already addressed. It was decided that Point is an implementation class and should not be used by user code. This was addressed by
HSEARCH-1315
.
This leaves a DistanceSortField and FullTextQuery#setSpatialParameters where the idea is to provide methods which don't need a explicit field name, but rather act upon the default spatial (field). The issue here, in particular with FullTextQuery, is the amount of overloaded methods.
According to @Kalgon:
If a constant for the default field name is available in a public (non-impl) location, then I wouldn't need the new methods which don't take the field name.
COORDINATES_DEFAULT_FIELD has actually already been moved into public API namely Spatial#COORDINATES_DEFAULT_FIELD. So this is covered as well. The only thing which worries me a bit with this, is that Spatial#COORDINATES_DEFAULT_FIELD is not terribly obvious. It is not even mentioned in the docs.
Bottom line, unless we want to add yet another method to FullTextQuery, I think we have covered everything. I'd suggest adding a note to the docs though regarding Spatial#COORDINATES_DEFAULT_FIELD though. Thoughts?
|
