| Louis Jacomet, Alex Snaps... I started working on updating hibernate-ehcache to use the new cache SPIs. Is this a good place to ask you guys about questions or difficulties I run into? The first one is regarding org.hibernate.cache.ehcache.internal.strategy.EhcacheAccessStrategyFactory. You have 2 impls: EhcacheAccessStrategyFactoryImpl and NonstopAccessStrategyFactory. Only NonstopAccessStrategyFactory is ever used - EhcacheAccessStrategyFactoryImpl is created in one spot, but only to pass to NonstopAccessStrategyFactory's ctor. The only distinction is this HibernateNonstopCacheExceptionHandler. As far as I can tell, we always use NonstopAccessStrategyFactory and NonstopAccessStrategyFactory#INSTANCE. Could this simply be collapsed to just always create "access strategy" objects with NonstopAccessStrategyFactory#INSTANCE? It would be nice to get rid of this EhcacheAccessStrategyFactoryImpl / NonstopAccessStrategyFactory distinction. I have not started on hibernate-jcache as of yet. If anyone wants to finish work on hibernate-ehcache or work on hibernate-jcache, let me know... |