Message Title

Benoit Besson created an issue

Issue Type:	Bug
Affects Versions:	5.2.1
Assignee:	Unassigned
Components:	hibernate-core
Created:	07/Jul/2016 13:52 PM
Priority:	Major
Reporter:	Benoit Besson

When using SchemaExport to generate DDL, the drop schema does not rely on the SchemaFilter to filter sequences.

The suggested correction is to add a call to this filter after ligne L243

https://github.com/aleksabl/hibernate-core/blob/master/hibernate-core/src/main/java/org/hibernate/tool/schema/internal/SchemaDropperImpl.java#L243

Current code :
Il faut faire la même chose sur SchemaDropperImpl:243

 
                                                                			for ( Sequence sequence : namespace.getSequences() ) {
				checkExportIdentifier( sequence, exportIdentifiers );
				applySqlStrings( dialect.getSequenceExporter().getSqlDropStrings( sequence, metadata ), formatter, options, targets );
			}

Suggested correction

 
                                                                			for ( Sequence sequence : namespace.getSequences() ) {
				if ( !schemaFilter.includeSequence( sequence ) ) {
					continue;
				}
				checkExportIdentifier( sequence, exportIdentifiers );
				applySqlStrings( dialect.getSequenceExporter().getSqlDropStrings( sequence, metadata ), formatter, options, targets );
			}
 
                                                            

Remark : this is done on the create schema in this line :

https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/tool/schema/internal/SchemaCreatorImpl.java#L285

This is just a mirror correction on the drop side.

Add Comment

This message was sent by Atlassian JIRA