|
I have to disagree here, this is a potential performance problem and one can't easily detect it, nor provide a test.
However I'd not take for granted that replacing the lock is correct; it is possible that a stronger lock was required here than what the method name would suggest.. but yes it's suspicious.
I'll send a pull request and ask Alex Snaps for an opinion on safety.
|