I just noticed that the OracleDialect was missing a registration for the standard function chr and would like to introduce a StandardFunctions class, which contains string constants for the various functions names that we consider “standard”. We can then use this class to write a test, which will check that functions are registered under these names. This would also be a nice place to put documentation on. I would also like to use these constants at the places where functions are registered/created, which will also allow to easily find possible definitions of such functions for various dialects. Newcomer dialects would also have a list of functions that they would have to implement, where developers of such dialects would probably now have to do a trial and error by running tests. |