|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
Hi Nicolas Helleringer, I had a closer look at your branch - https://github.com/nicolashelleringer/hibernate-search/tree/HSEARCH-809 - and added a whole bunch of comments. Looks good so far. What I think we should look at, however, is how we can integrate the additional functionality we get via native faceting into the existing Hibernate Search facet API. I would prefer to not expose Lucene specific APIs, instead keep/extend our API and make it just a configuration option (or API call) to use the different faceting approaches. The user gets then the choice between native Lucene faceting and collector based faceting. Of course there is no "cheap" opt in and out between these two approaches, since the Lucene approach requires the use of @Facet to index the taxonomy. WDYT?
On a different note, I also see the same errors after rebasing onto master. I will also look into it.
Last but not least, did you make any progress on the limitations you mentioned?