|
From today's triage meeting:
Steve Ebersole 12:08 PM: i am saying either: 1) we'd create a aux db object per table to do the insert 2) stuff all the inserts into org.hibernate.boot.model.relational.Database#initCommands initCommands is picked up during schema export (creation) its where the user's "import.sql" ends upo Steve Ebersole 12:09 PM: i am just saying to build on top of that but thats the danger if they also have a import.sql those would be in Database#initCommands and we'd not want them there Gail Badner 12:10 PM: didn't realize that's how import.sql got processed Steve Ebersole 12:10 PM: yes, also jpa's equiv creation script they call it Steve Ebersole 12:13 PM: the concern i have with those 2 approaches is the we'd build on top of their supplied init commands or supplied aux db objects, with no way to filter them perhaps HHH-9876 should have the ability to filter these as well JIRA 12:13 PM HHH-9876 : Ability to filter objects from Database for schema tooling Reported by Marcus Klimstra Type: New Feature Priority: Major Status: Open Steve Ebersole 12:14 PM: the idea being that when we do this, we need to filter OUT everything from schema export that is NOT part of envers schema i guess schema update could handle the creation part Steve Ebersole 12:15 PM: but that does not account for the inserts Steve Ebersole 12:16 PM: i meant to say that schema migration could handle the table creations without a filter but it would not handle the inserts Steve Ebersole12:18 PM: yeah, so basically i am advocating something like https://github.com/hydra1983/hibernate-envers-tools Steve Ebersole 12:19 PM: thats what I mean by one off a tool they run from build/cml Gail Badner 12:22 PM: yes, I looked at that a while back Steve Ebersole 12:23 PM: ultimately i want to commonize our cml tools we duplicate so much logic but this would fit in well there i'll think about that some for 5.1 then
|