|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
Dustin, yes, I think creating a pull request for this issue would be great. Have you used the "git rebase -i HEAD~NNN" command yet to squash your separate (related) commits into one commit? That usually makes it easier to deal with the change for various reasons.
Basically, NNN will usually correspond to the number of your commits that show up at the top of "git log". If you have made unrelated changes in the git branch, care must be taken to not squash those with the HHH-7747 fix. Most people like to create a new local branch for each change. If I recall correctly, I think you are on the 4.1 branch but haven't mixed other changes in, so squashing the commits into one, should be easy.
As mentioned on the hibernate-dev mailing list (last week), the build of 4.1.9 will be done on Wednesday (December 12th). I'm thinking that we should include the HHH-7850 fix also if possible. If that can be addressed by Wednesday, then we will be good for upgrading the javassist jar also. We can also discuss the timing of these fixes with Brmeyer/sebersole on irc. Steve (sebersole) is the lead for the Hibernate project by the way (in case you didn't know).
Just to explain quickly the relationship behind these changes. HHH-7435 is about upgrading javassist to 3.17.1 to resolve a performance bottleneck. We have not found the reason why but HHH-7850 only occurs with javassist 3.17.1 with Java7.
Scott