I believe you're looking at the wrong PR associated with this issue, as you should be looking at https://github.com/hibernate/hibernate-orm/pull/1745. As I have said multiple times already, my implementation builds off SQLServer2005LimitHandler and not AbstractLimitHandler. I just compared 5.2.6, 5.2.7, and 5.2.8 (currently master) to see what differences exist that could impact behavior. Besides my PR, there was only one minor bug-fix to the LimitHandler implementation,
HHH-11352 Closed (https://github.com/hibernate/hibernate-orm/commit/56f7466d52b49456bbf0178f7666d320de4812e1). You have a couple options here. You can clone the github repository and elect to use the tags 5.2.6, 5.2.7, or even master. Just be aware when using 5.2.6, you should cherry-pick the above commit I listed for
HHH-11352 Closed so that you get proper functionality for some corner use cases. In all three scenarios, you would need to overlay my PR (PR #1745, linked above) on top of all that and then build the jars. |