9:42 a.m.
Expose validated bean via ConstraintValidatorContext
----------------------------------------------------
Key: BVAL-237
URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237
Project: Bean Validation
Issue Type: New Feature
Components: spec-general
Affects Versions: 1.0 final
Reporter: Gunnar Morling
Fix For: 1.1
In the feedback forum a user
[suggested|https://forum.hibernate.org/viewtopic.php?f=26&t=1012111] to expose the
currently validated bean via {{javax.validation.ConstraintValidatorContext}}.
IMO that's a good addition as it would people allow to create custom cross-field
constraints more easily. I'm not sure whether access should be restricted to the
current leaf bean or whether also the root bean should be accessible. In the latter case
some methods from {{ConstraintViolation}} might just be offered on
{{ConstraintValidatorContext}} as well:
{code:java}
getConstraintDescriptor()
getLeafBean()
getPropertyPath()
getRootBean()
getRootBeanClass()
{code}
Another idea would be to have an {{unwrap()}} method on {{ConstraintValidatorContext}}
which would allow for BV providers to expose additional functionality. WDYT?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:45 p.m.
New subject: [Hibernate-JIRA] Commented: (BVAL-237) Expose validated bean via ConstraintValidatorContext
[
http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237?page=c...
]
Gunnar Morling commented on BVAL-237:
-------------------------------------
Should have. I think this shouldn't be a big effort and it would pave the way for new
kinds of custom constraints by users and BV providers.
Expose validated bean via ConstraintValidatorContext
----------------------------------------------------
Key: BVAL-237
URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237
Project: Bean Validation
Issue Type: New Feature
Components: spec-general
Affects Versions: 1.0 final
Reporter: Gunnar Morling
Fix For: 1.1
In the feedback forum a user
[suggested|https://forum.hibernate.org/viewtopic.php?f=26&t=1012111] to expose the
currently validated bean via {{javax.validation.ConstraintValidatorContext}}.
IMO that's a good addition as it would people allow to create custom cross-field
constraints more easily. I'm not sure whether access should be restricted to the
current leaf bean or whether also the root bean should be accessible. In the latter case
some methods from {{ConstraintViolation}} might just be offered on
{{ConstraintValidatorContext}} as well:
{code:java}
getConstraintDescriptor()
getLeafBean()
getPropertyPath()
getRootBean()
getRootBeanClass()
{code}
Another idea would be to have an {{unwrap()}} method on {{ConstraintValidatorContext}}
which would allow for BV providers to expose additional functionality. WDYT?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:04 p.m.
New subject: [Hibernate-JIRA] Commented: (BVAL-237) Expose validated bean via ConstraintValidatorContext
[
http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237?page=c...
]
Emmanuel Bernard commented on BVAL-237:
---------------------------------------
What use case do you see?
It is related to BVAL-240 (cross field validation), do you have any other use case?
Expose validated bean via ConstraintValidatorContext
----------------------------------------------------
Key: BVAL-237
URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237
Project: Bean Validation
Issue Type: New Feature
Components: spec-general
Affects Versions: 1.0 final
Reporter: Gunnar Morling
Fix For: 1.1
In the feedback forum a user
[suggested|https://forum.hibernate.org/viewtopic.php?f=26&t=1012111] to expose the
currently validated bean via {{javax.validation.ConstraintValidatorContext}}.
IMO that's a good addition as it would people allow to create custom cross-field
constraints more easily. I'm not sure whether access should be restricted to the
current leaf bean or whether also the root bean should be accessible. In the latter case
some methods from {{ConstraintViolation}} might just be offered on
{{ConstraintValidatorContext}} as well:
{code:java}
getConstraintDescriptor()
getLeafBean()
getPropertyPath()
getRootBean()
getRootBeanClass()
{code}
Another idea would be to have an {{unwrap()}} method on {{ConstraintValidatorContext}}
which would allow for BV providers to expose additional functionality. WDYT?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:08 p.m.
New subject: [Hibernate-JIRA] Commented: (BVAL-237) Expose validated bean via ConstraintValidatorContext
[
http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237?page=c...
]
Gunnar Morling commented on BVAL-237:
-------------------------------------
First of all cross-field validation. Using the parent bean in error messages would be
another use case.
Expose validated bean via ConstraintValidatorContext
----------------------------------------------------
Key: BVAL-237
URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237
Project: Bean Validation
Issue Type: New Feature
Components: spec-general
Affects Versions: 1.0 final
Reporter: Gunnar Morling
Fix For: 1.1
In the feedback forum a user
[suggested|https://forum.hibernate.org/viewtopic.php?f=26&t=1012111] to expose the
currently validated bean via {{javax.validation.ConstraintValidatorContext}}.
IMO that's a good addition as it would people allow to create custom cross-field
constraints more easily. I'm not sure whether access should be restricted to the
current leaf bean or whether also the root bean should be accessible. In the latter case
some methods from {{ConstraintViolation}} might just be offered on
{{ConstraintValidatorContext}} as well:
{code:java}
getConstraintDescriptor()
getLeafBean()
getPropertyPath()
getRootBean()
getRootBeanClass()
{code}
Another idea would be to have an {{unwrap()}} method on {{ConstraintValidatorContext}}
which would allow for BV providers to expose additional functionality. WDYT?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:35 p.m.
New subject: [Hibernate-JIRA] Commented: (BVAL-237) Expose validated bean via ConstraintValidatorContext
[
http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237?page=c...
]
Emmanuel Bernard commented on BVAL-237:
---------------------------------------
My main problem with that is leakage. Forget validateValue, forget reliable validate based
on changesets.
Expose validated bean via ConstraintValidatorContext
----------------------------------------------------
Key: BVAL-237
URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237
Project: Bean Validation
Issue Type: New Feature
Components: spec-general
Affects Versions: 1.0 final
Reporter: Gunnar Morling
Fix For: 1.1
In the feedback forum a user
[suggested|https://forum.hibernate.org/viewtopic.php?f=26&t=1012111] to expose the
currently validated bean via {{javax.validation.ConstraintValidatorContext}}.
IMO that's a good addition as it would people allow to create custom cross-field
constraints more easily. I'm not sure whether access should be restricted to the
current leaf bean or whether also the root bean should be accessible. In the latter case
some methods from {{ConstraintViolation}} might just be offered on
{{ConstraintValidatorContext}} as well:
{code:java}
getConstraintDescriptor()
getLeafBean()
getPropertyPath()
getRootBean()
getRootBeanClass()
{code}
Another idea would be to have an {{unwrap()}} method on {{ConstraintValidatorContext}}
which would allow for BV providers to expose additional functionality. WDYT?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:41 p.m.
New subject: [Hibernate-JIRA] Commented: (BVAL-237) Expose validated bean via ConstraintValidatorContext
[
http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237?page=c...
]
Emmanuel Bernard commented on BVAL-237:
---------------------------------------
I have opened a separate issue for the unwrap BVAL-249
Expose validated bean via ConstraintValidatorContext
----------------------------------------------------
Key: BVAL-237
URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237
Project: Bean Validation
Issue Type: New Feature
Components: spec-general
Affects Versions: 1.0 final
Reporter: Gunnar Morling
Fix For: 1.1
In the feedback forum a user
[suggested|https://forum.hibernate.org/viewtopic.php?f=26&t=1012111] to expose the
currently validated bean via {{javax.validation.ConstraintValidatorContext}}.
IMO that's a good addition as it would people allow to create custom cross-field
constraints more easily. I'm not sure whether access should be restricted to the
current leaf bean or whether also the root bean should be accessible. In the latter case
some methods from {{ConstraintViolation}} might just be offered on
{{ConstraintValidatorContext}} as well:
{code:java}
getConstraintDescriptor()
getLeafBean()
getPropertyPath()
getRootBean()
getRootBeanClass()
{code}
Another idea would be to have an {{unwrap()}} method on {{ConstraintValidatorContext}}
which would allow for BV providers to expose additional functionality. WDYT?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:07 a.m.
New subject: [Hibernate-JIRA] Commented: (BVAL-237) Expose validated bean via ConstraintValidatorContext
[
https://hibernate.onjira.com/browse/BVAL-237?page=com.atlassian.jira.plug...
]
Hardy Ferentschik commented on BVAL-237:
----------------------------------------
I see that as a very useful feature as well
{quote}
What use case do you see?
It is related to BVAL-240 (cross field validation), do you have any other use case?
{quote}
Another usecase is to generate customized error messages. If you know the property you are
evaluating you can incorporate this into the error message (in a generic way).
{quote}
My main problem with that is leakage. Forget validateValue, forget reliable validate based
on changesets.
{quote}
I don't understand what you mean with that.
Expose validated bean via ConstraintValidatorContext
----------------------------------------------------
Key: BVAL-237
URL: https://hibernate.onjira.com/browse/BVAL-237
Project: Bean Validation
Issue Type: New Feature
Components: spec-general
Affects Versions: 1.0 final
Reporter: Gunnar Morling
Fix For: 1.1
In the feedback forum a user
[suggested|https://forum.hibernate.org/viewtopic.php?f=26&t=1012111] to expose the
currently validated bean via {{javax.validation.ConstraintValidatorContext}}.
IMO that's a good addition as it would people allow to create custom cross-field
constraints more easily. I'm not sure whether access should be restricted to the
current leaf bean or whether also the root bean should be accessible. In the latter case
some methods from {{ConstraintViolation}} might just be offered on
{{ConstraintValidatorContext}} as well:
{code:java}
getConstraintDescriptor()
getLeafBean()
getPropertyPath()
getRootBean()
getRootBeanClass()
{code}
Another idea would be to have an {{unwrap()}} method on {{ConstraintValidatorContext}}
which would allow for BV providers to expose additional functionality. WDYT?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:07 a.m.
New subject: [Hibernate-JIRA] Issue Comment Edited: (BVAL-237) Expose validated bean via ConstraintValidatorContext
[
https://hibernate.onjira.com/browse/BVAL-237?page=com.atlassian.jira.plug...
]
Hardy Ferentschik edited comment on BVAL-237 at 2/28/12 4:07 AM:
-----------------------------------------------------------------
I see that as a very useful feature as well
{quote}
What use case do you see?
It is related to BVAL-240 (cross field validation), do you have any other use case?
{quote}
Another usecase is to generate customized error messages. If you know the property you are
evaluating you can incorporate this into the error message (in a generic way).
{quote}
My main problem with that is leakage. Forget validateValue, forget reliable validate based
on changesets.
{quote}
I don't understand what you mean with that. Can you elaborate?
was (Author: hardy.ferentschik):
I see that as a very useful feature as well
{quote}
What use case do you see?
It is related to BVAL-240 (cross field validation), do you have any other use case?
{quote}
Another usecase is to generate customized error messages. If you know the property you are
evaluating you can incorporate this into the error message (in a generic way).
{quote}
My main problem with that is leakage. Forget validateValue, forget reliable validate based
on changesets.
{quote}
I don't understand what you mean with that.
Expose validated bean via ConstraintValidatorContext
----------------------------------------------------
Key: BVAL-237
URL: https://hibernate.onjira.com/browse/BVAL-237
Project: Bean Validation
Issue Type: New Feature
Components: spec-general
Affects Versions: 1.0 final
Reporter: Gunnar Morling
Fix For: 1.1
In the feedback forum a user
[suggested|https://forum.hibernate.org/viewtopic.php?f=26&t=1012111] to expose the
currently validated bean via {{javax.validation.ConstraintValidatorContext}}.
IMO that's a good addition as it would people allow to create custom cross-field
constraints more easily. I'm not sure whether access should be restricted to the
current leaf bean or whether also the root bean should be accessible. In the latter case
some methods from {{ConstraintViolation}} might just be offered on
{{ConstraintValidatorContext}} as well:
{code:java}
getConstraintDescriptor()
getLeafBean()
getPropertyPath()
getRootBean()
getRootBeanClass()
{code}
Another idea would be to have an {{unwrap()}} method on {{ConstraintValidatorContext}}
which would allow for BV providers to expose additional functionality. WDYT?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:20 p.m.
New subject: [Hibernate-JIRA] Commented: (BVAL-237) Expose validated bean via ConstraintValidatorContext
[
https://hibernate.onjira.com/browse/BVAL-237?page=com.atlassian.jira.plug...
]
Emmanuel Bernard commented on BVAL-237:
---------------------------------------
{quote}bq. My main problem with that is leakage. Forget validateValue, forget reliable
validate based on changesets.
I don't understand what you mean with that. Can you elaborate?{quote}
If a constraint validator is relying on the presence of the bean object, it will fail when
validateValue is used as no bean instance is there. Assuming we add a changeset API to
validate an object based on a set of potential changes. The object will not have the
changeset applied to it and the logic using the bean instance my be tricked.
Expose validated bean via ConstraintValidatorContext
----------------------------------------------------
Key: BVAL-237
URL: https://hibernate.onjira.com/browse/BVAL-237
Project: Bean Validation
Issue Type: New Feature
Components: spec-general
Affects Versions: 1.0 final
Reporter: Gunnar Morling
Fix For: 1.1
In the feedback forum a user
[suggested|https://forum.hibernate.org/viewtopic.php?f=26&t=1012111] to expose the
currently validated bean via {{javax.validation.ConstraintValidatorContext}}.
IMO that's a good addition as it would people allow to create custom cross-field
constraints more easily. I'm not sure whether access should be restricted to the
current leaf bean or whether also the root bean should be accessible. In the latter case
some methods from {{ConstraintViolation}} might just be offered on
{{ConstraintValidatorContext}} as well:
{code:java}
getConstraintDescriptor()
getLeafBean()
getPropertyPath()
getRootBean()
getRootBeanClass()
{code}
Another idea would be to have an {{unwrap()}} method on {{ConstraintValidatorContext}}
which would allow for BV providers to expose additional functionality. WDYT?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:08 a.m.
New subject: [Hibernate-JIRA] (BVAL-237) Expose validated bean via ConstraintValidatorContext
10:08 a.m.
New subject: [Hibernate-JIRA] (BVAL-237) Expose validated bean via ConstraintValidatorContext
5:56 p.m.
New subject: [Hibernate-JIRA] (BVAL-237) Expose validated bean via ConstraintValidatorContext
4090
days inactive
4646
days old
hibernate-issues@lists.jboss.org
11 comments
4 participants
participants (4)
-
Emmanuel Bernard (JIRA) -
Gunnar Morling (JIRA)
-
Hardy Ferentschik (JIRA)
-
Vivian Steller (JIRA)