4:39 p.m.
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Type: Bug
Components: core
Versions: 3.1.3
Reporter: Kenny MacLeod
Priority: Trivial
This one is no great shakes, but the first line of QueryKey.equals() casts the argument to
QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6:59 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Rafal Boniecki commented on HHH-2021:
-------------------------------------
This issue is much more important than it may seem at first - especially for JBoss Cache
users. Under high load with Query Cache enabled there is following exception thrown:
2007-08-06 17:21:46,347 ERROR [STDERR] Exception in thread "Timer-3"
2007-08-06 17:21:46,347 ERROR [STDERR] java.lang.ClassCastException:
org.hibernate.cache.CacheKey cannot be cast to org.hibernate.cache.QueryKey
2007-08-06 17:21:46,348 ERROR [STDERR] at
org.hibernate.cache.QueryKey.equals(QueryKey.java:54)
2007-08-06 17:21:46,348 ERROR [STDERR] at
java.util.AbstractList.equals(AbstractList.java:507)
2007-08-06 17:21:46,348 ERROR [STDERR] at org.jboss.cache.Fqn.equals(Unknown Source)
2007-08-06 17:21:46,348 ERROR [STDERR] at
java.util.HashMap.removeEntryForKey(HashMap.java:556)
2007-08-06 17:21:46,348 ERROR [STDERR] at java.util.HashMap.remove(HashMap.java:538)
2007-08-06 17:21:46,348 ERROR [STDERR] at
java.util.LinkedHashMap$LinkedHashIterator.remove(LinkedHashMap.java:366)
2007-08-06 17:21:46,348 ERROR [STDERR] at
org.jboss.cache.eviction.LRUAlgorithm.prune(Unknown Source)
2007-08-06 17:21:46,348 ERROR [STDERR] at
org.jboss.cache.eviction.BaseEvictionAlgorithm.process(Unknown Source)
2007-08-06 17:21:46,349 ERROR [STDERR] at
org.jboss.cache.eviction.EvictionTimerTask.run(Unknown Source)
2007-08-06 17:21:46,349 ERROR [STDERR] at java.util.TimerThread.mainLoop(Timer.java:512)
2007-08-06 17:21:46,349 ERROR [STDERR] at java.util.TimerThread.run(Timer.java:462)
which kills eviction queue thread (this thread empties eviction queue every defined amount
of time). Without this thread eviction queue fills up and then JBoss stops responding.
Adding instanceof check before cast as mentioned above makes the problem go away :)
Please fix this simple bug.
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Priority: Trivial
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:50 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Bernard Niset commented on HHH-2021:
------------------------------------
I had the same problem when using EhCache. So, it seems important for EhCache users as
well.
It seems to happen very rarely but it doesn't seem like minor issue as it completely
crashes the application when the use case leading to it happens. Perhaps it should be
investigated how this problem happens (mixing QueryKey elements and entities in the same
cache region ?), but in the meanwhile it seems easy enough to fix.
Please note that the issue happened in a different case for me. I'll paste below the
stacktrace that happened in my case.
2007-10-22 02:09:55,441 ERROR RuntimeException caught: org.hibernate.cache.CacheKey
cannot be cast to
org.hibernate.cache.QueryKey
java.lang.ClassCastException: org.hibernate.cache.CacheKey cannot be cast to
org.hibernate.cache.QueryKey
at org.hibernate.cache.QueryKey.equals(QueryKey.java:54)
at java.util.HashMap.removeEntryForKey(HashMap.java:556)
at java.util.LinkedHashMap.addEntry(LinkedHashMap.java:411)
at java.util.HashMap.put(HashMap.java:385)
at net.sf.ehcache.store.MemoryStore.put(MemoryStore.java:107)
at net.sf.ehcache.Cache.put(Cache.java:569)
at net.sf.ehcache.Cache.put(Cache.java:522)
at org.hibernate.cache.EhCache.put(EhCache.java:119)
at org.hibernate.cache.ReadWriteCache.put(ReadWriteCache.java:159)
at org.hibernate.engine.TwoPhaseLoad.initializeEntity(TwoPhaseLoad.java:156)
at org.hibernate.loader.Loader.initializeEntitiesAndCollections(Loader.java:854)
at org.hibernate.loader.Loader.doQuery(Loader.java:729)
at
org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:236)
at org.hibernate.loader.Loader.doList(Loader.java:2220)
at org.hibernate.loader.Loader.listIgnoreQueryCache(Loader.java:2104)
at org.hibernate.loader.Loader.list(Loader.java:2099)
at org.hibernate.loader.hql.QueryLoader.list(QueryLoader.java:378)
at org.hibernate.hql.ast.QueryTranslatorImpl.list(QueryTranslatorImpl.java:338)
at org.hibernate.engine.query.HQLQueryPlan.performList(HQLQueryPlan.java:172)
at org.hibernate.impl.SessionImpl.list(SessionImpl.java:1121)
at org.hibernate.impl.QueryImpl.list(QueryImpl.java:79)
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Priority: Trivial
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:59 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Suzanne Weller commented on HHH-2021:
-------------------------------------
This is causing the same problem for my custom cache implementation which holds both
entities and queries in the same underlying map. It seems like a quick fix and an
unnecessary assumption that a QueryKey will never be used in a map which also contains
keys with different types.
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Priority: Trivial
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:08 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Bernard Niset commented on HHH-2021:
------------------------------------
Unfortunately, the fix for this bug didn't make it in 3.2.6 according to the
changelog. It is too bad for a one line fix.
I would like to emphasize on the fact it affects all versions not just 3.1.3 like
indicated in header of this bug.
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Priority: Trivial
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:57 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Gail Badner updated HHH-2021:
-----------------------------
Assignee: Gail Badner
Fix Version/s: 3.3
3.2.x
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Steve Ebersole updated HHH-2021:
--------------------------------
Fix Version/s: (was: 3.3.0.CR1)
3.3.0
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3.0
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:24 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Alexandre Juffet commented on HHH-2021:
---------------------------------------
well, this bug is greatly impacting us on a live application so if no one submit a patch,
i'll try ^^.
configuration is Hibernate 3.2.6ga and ehcache 1.2.3.
as M. Nisset pointed out we've used the same cache region for objects and query cache
and seems a very plausible source of the problem.
possible mitigation may be done by turning the query cache off by configuration.
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3.0
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:44 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Alexandre Juffet updated HHH-2021:
----------------------------------
Attachment: patch.zip
just the one line patch for the equals(Object obj) if the passed object is not an instance
of QueryKey it will not throw a CCE.
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3.0
Attachments: patch.zip
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:40 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Gail Badner commented on HHH-2021:
----------------------------------
This was fixed in trunk in revision 14617.
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3.0
Attachments: patch.zip
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:40 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Gail Badner commented on HHH-2021:
----------------------------------
Thiw was fixed in trunk in revision 14617.
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3.0
Attachments: patch.zip
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:40 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Gail Badner updated HHH-2021:
-----------------------------
Comment: was deleted
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3.0
Attachments: patch.zip
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:24 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Gail Badner resolved HHH-2021.
------------------------------
Resolution: Fixed
Fixed in trunk / 3.2
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3.0
Attachments: patch.zip
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:24 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Gail Badner closed HHH-2021.
----------------------------
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3.0
Attachments: patch.zip
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:14 p.m.
New subject: [Hibernate-JIRA] Reopened: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Steve Ebersole reopened HHH-2021:
---------------------------------
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3.0.GA
Attachments: patch.zip
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:14 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=c...
]
Steve Ebersole closed HHH-2021.
-------------------------------
Resolution: Fixed
Fix Version/s: (was: 3.3.x)
3.3.0.GA
org.hibernate.cache.QueryKey has a fragile equals() method
----------------------------------------------------------
Key: HHH-2021
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.1.3
Reporter: Kenny MacLeod
Assignee: Gail Badner
Priority: Trivial
Fix For: 3.2.x, 3.3.0.GA
Attachments: patch.zip
This one is no great shakes, but the first line of QueryKey.equals() casts the argument
to QueryKey without checking for its type. As such, the method is fragile.
It should be consistent with CacheKey, which does an instanceof check before the cast.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5732
days inactive
6456
days old
hibernate-issues@lists.jboss.org
15 comments
7 participants
participants (7)
-
Alexandre Juffet (JIRA) -
Bernard Niset (JIRA)
-
Gail Badner (JIRA)
-
Kenny MacLeod (JIRA)
-
Rafal Boniecki (JIRA)
-
Steve Ebersole (JIRA)
-
Suzanne Weller (JIRA)