[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Scott Marlow reassigned HHH-5222: --------------------------------- Assignee: Scott Marlow -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Scott Marlow commented on HHH-5222: ----------------------------------- I don't think there is a patch for this issue yet. I did make a code fix for HHH-5032 and that was committed. Then, more testing showed additional (related) issues. The mentioned patch is the test. I intended to look at this issue again but didn't yet. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Robert Mlekus commented on HHH-5222: ------------------------------------ javax.persistence.EntityManager.lock(object, javax.persistence.LockModeType.WRITE) is broken in hibernate 3.6.4 (jboss-6.1.0-snapshot), too (was working in Hibernte 3.3.1 (JBoss 5.1.0)) workaround: replace the javax.persistence EntityManager.lock with a HibernateSession.locklock( item, LockMode.FORCE ); (which makes the code hibernate specific, though!) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Christian Bauer updated HHH-5222: --------------------------------- Affects Version/s: 3.6.8 4.0.0.CR6 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Scott Marlow edited comment on HHH-5222 at 11/23/11 10:42 AM: -------------------------------------------------------------- We can also change to LockMode.OPTIMISTIC( 6 ) but it shouldn't matter whether LockMode.OPTIMISTIC is higher/lower than LockMode.READ (5). /me needs to verify this further... ;) was (Author: smarlow(a)redhat.com): From a JPA point of view, LockModeType.READ is supposed to equal LockModeType.OPTIMISTIC. LockModeType.WRITE is supposed to equal LockModeType.OPTIMISTIC_FORCE_INCREMENT. I think the important change is to LockMode.OPTIMISTIC_FORCE_INCREMENT( 7 ). We can also change to LockMode.OPTIMISTIC( 6 ) but it shouldn't matter whether LockMode.OPTIMISTIC is higher/lower than LockMode.READ (6). /me needs to verify this further... ;) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Scott Marlow commented on HHH-5222: ----------------------------------- The mapping itself, from JPA to Hibernate seems correct to me too. If we change hibernate.LockMode.OPTIMISTIC(3) to hibernate.LockMode.OPTIMISTIC(6), we will go through the upgrade steps for that transition. If we change hibernate.LockMode.OPTIMISTIC_FORCE_INCREMENT(4) to hibernate.LockMode.OPTIMISTIC_FORCE_INCREMENT(7), I think that covers (entering the upgrade steps for) the transition from READ to OPTIMISTIC_FORCE_INCREMENT. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Scott Marlow commented on HHH-5222: ----------------------------------- That would of been me and I missed this transition case. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Scott Marlow commented on HHH-5222: ----------------------------------- code change is pushed here https://github.com/scottmarlow/hibernate-core/tree/HHH-5222 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Scott Marlow updated HHH-5222: ------------------------------ Fix Version/s: 4.0.0.next -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Strong Liu reopened HHH-5222: ----------------------------- reopen this since the test fails on mysql {code} org.hibernate.ResourceClosedException: This TransactionCoordinator has been closed at org.hibernate.engine.transaction.internal.TransactionCoordinatorImpl.getTransaction(TransactionCoordinatorImpl.java:184) at org.hibernate.engine.transaction.internal.TransactionCoordinatorImpl.isTransactionInProgress(TransactionCoordinatorImpl.java:160) at org.hibernate.internal.SessionImpl.isTransactionInProgress(SessionImpl.java:462) at org.hibernate.ejb.AbstractEntityManagerImpl.isTransactionInProgress(AbstractEntityManagerImpl.java:1117) at org.hibernate.ejb.EntityManagerImpl.close(EntityManagerImpl.java:133) at org.hibernate.ejb.test.BaseEntityManagerFunctionalTestCase.releaseUnclosedEntityManager(BaseEntityManagerFunctionalTestCase.java:230) at org.hibernate.ejb.test.BaseEntityManagerFunctionalTestCase.releaseUnclosedEntityManagers(BaseEntityManagerFunctionalTestCase.java:215) at org.hibernate.ejb.test.BaseEntityManagerFunctionalTestCase.releaseResources(BaseEntityManagerFunctionalTestCase.java:203) at sun.reflect.GeneratedMethodAccessor49.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:37) at org.hibernate.testing.junit4.FailureExpectedHandler.evaluate(FailureExpectedHandler.java:59) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.hibernate.testing.junit4.BeforeClassCallbackHandler.evaluate(BeforeClassCallbackHandler.java:43) at org.hibernate.testing.junit4.AfterClassCallbackHandler.evaluate(AfterClassCallbackHandler.java:42) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:51) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:63) at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:49) at sun.reflect.GeneratedMethodAccessor105.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) at org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:75) at $Proxy3.processTestClass(Unknown Source) at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:86) at sun.reflect.GeneratedMethodAccessor104.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) at org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.messaging.remote.internal.MethodInvocationUnmarshallingDispatch.dispatch(MethodInvocationUnmarshallingDispatch.java:48) at org.gradle.messaging.dispatch.DiscardOnFailureDispatch.dispatch(DiscardOnFailureDispatch.java:31) at org.gradle.messaging.dispatch.AsyncDispatch.dispatchMessages(AsyncDispatch.java:129) at org.gradle.messaging.dispatch.AsyncDispatch.access$000(AsyncDispatch.java:33) at org.gradle.messaging.dispatch.AsyncDispatch$1.run(AsyncDispatch.java:69) at org.gradle.messaging.concurrent.DefaultExecutorFactory$StoppableExecutorImpl$1.run(DefaultExecutorFactory.java:63) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) {code} form now on, I will reopen any jira which breaks our matrix testing job https://ci.jboss.org/hudson/job/hibernate-core-master-matrix/ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Strong Liu commented on HHH-5222: --------------------------------- don't know why it failed and now passes, but yes, let's close this -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5222?page=c... ] Scott Marlow closed HHH-5222. ----------------------------- -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira