Author: borges Date: 2012-02-27 10:02:43 -0500 (Mon, 27 Feb 2012) New Revision: 12198 Modified: trunk/etc/findbugs-exclude.xml Log: findbugs: Correct filter rules. Modified: trunk/etc/findbugs-exclude.xml =================================================================== --- trunk/etc/findbugs-exclude.xml 2012-02-24 21:19:02 UTC (rev 12197) +++ trunk/etc/findbugs-exclude.xml 2012-02-27 15:02:43 UTC (rev 12198) @@ -20,14 +20,26 @@ <Or> <Method name="compare" params="java.lang.Integer,java.lang.Integer" returns="boolean"/> <Method name="compare" params="java.lang.Long,java.lang.Long" returns="boolean"/> - <Method name="compare" params="java.lang.String,java.lang.String" returns="boolean"/> - <Method name="compare" params="java.lang.Boolean,java.lang.Boolean" returns="boolean"/> <Method name="compare" params="java.lang.Double,java.lang.Double" returns="boolean"/> </Or> <Bug pattern="RC_REF_COMPARISON"/> </Match> + <!-- Comparison is correct within its context --> <Match> + <Class name="org.hornetq.ra.Util"/> + <Method name="compare" params="java.lang.Boolean,java.lang.Boolean" returns="boolean"/> + <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN"/> + </Match> + + <!-- Comparison is correct within its context --> + <Match> + <Class name="org.hornetq.ra.Util"/> + <Method name="compare" params="java.lang.String,java.lang.String" returns="boolean"/> + <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ"/> + </Match> + + <Match> <!-- As per Java Messaging Specification 3.5.4: "