On 12-09-21 2:34 PM, Manik Surtani wrote:

Looks good, except that the pseudocode for dealing with a CancellableCommand (on the recipient node) should look like:

* Receive command

* if CancellableCommand, register with CancellationService

* Perform command

* If CancellableCommand, un-register from CancellationService

That last step was missing from your detail below.  I presume that would require a CancellationService#unregisterThread(UUID u) ?

I was looking at the most appropriate place for this logic and I think InboundInvocationHandlerImpl#handleInternal method and its try/catch/finally clause fits the bill, would you agree?