On 25 Oct 2010, at 15:34, Vladimir Blagojevic wrote:


On 2010-10-25, at 7:51 AM, Mircea Markus wrote:

I've created https://jira.jboss.org/browse/ISPN-731
Vladimir, mind taking a look into this one as you're familiar with the code re:state transfer?

Can't we factorize the code common Leave and Join code and still use a single thread to do all the action? There's no point in using two threads that run in sequence (unless they do some parallel processing?).

Umm, nope.  :)  One is a push and one is a pull.  Very different.
Can't we just do push and no push(xor pull)? I guess my basic question is: what do we get by doing both push and pull at the same time? Any operation happening in parallel which would make things faster?  


Mircea, Have a look at the old LeaveTask.java. Pushing state on leave is complicated! Hence InvertedLeaveTask.java which pulls state just like join task. We share a lot of code with JoinTask, it is easier to maintain, comprehend etc etc. 
I see. So the only reason to have both push and pull is code reuse? 
_______________________________________________
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev