On 10/27/2011 12:15 AM, Michal Linhard wrote:

On 10/26/2011 06:29 PM, Galder Zamarreño wrote:

First of all, what is the problem that the Hot Rod client has depending on core/ as it is? It's not clear from the JIRA.

Personally, what I don't like about the infinispan-core dependency is 
that it makes you falsely think that you should keep the infinispan-core 
version in sync on both sides.

But that's not true. You should be able to use infinispan-core as old as 
the Hot rod protocol version allows even with the newest infinispan. 
OTOH This problem will actually exist even with refactored packaging.

Actually, what I don't like is the fact that we say that this client is 
e.g. infinispan 5.1.0.BETA2, but actually we should be saying that this 
client supports hotrod v1 - infinispan version shouldn't bother us on

I like the JDBC comparison: when you connect to a database you are not expected to:

use exactly the same version of the client as the server
embed the server in the client

I just built an empty project with the infinispan-hotrod-client dependency and it brings in the following:

224958 2011-10-21 14:13 WEB-INF/lib/jboss-marshalling-1.3.0.GA.jar 96221 2011-10-21 14:13 WEB-INF/lib/commons-pool-1.5.4.jar 7635 2011-10-21 14:13 WEB-INF/lib/rhq-pluginAnnotations-3.0.1.jar 70928 2011-10-21 14:13 WEB-INF/lib/jandex-1.0.3.Final.jar 149649 2011-10-25 11:10 WEB-INF/lib/infinispan-client-hotrod-5.1.0.BETA2.jar 80929 2011-10-21 14:13 WEB-INF/lib/jboss-marshalling-river-1.3.0.GA.jar 1760173 2011-10-21 14:12 WEB-INF/lib/jgroups-3.0.0.CR5.jar 50251 2011-10-21 14:13 WEB-INF/lib/jboss-logging-3.0.0.GA.jar 10899 2011-10-21 14:13 WEB-INF/lib/jboss-transaction-api-1.0.1.GA.jar 1601837 2011-10-21 14:12 WEB-INF/lib/infinispan-core-5.1.0.BETA2.jar

For a grand total of just over 4MB. As Yoda would say, "size matters not", but seeing pointless dependencies in there such as jgroups, rhq-pluginAnnotations and jandex does make it look unpolished and unprofessional.

Tristan