On 03 Apr 2014, at 11:38, Radim Vansa <rvansa@redhat.com> wrote:Hi, looking on the new configuration parser, I've noticed that you cannot configure ConsistentHashFactory anymore - is this by purpose?^ Rather than being something the users should be tweaking, it’s something that’s used internally. So, I applied a bit of if-in-doubt-leave-it-out logic. I don’t think we lose any major functionality with this.
Another my concern is the fact that you enable stuff by parsing the element - for example L1. I expect that omitting the element and setting it with the default value (as presented in XSD) makes no difference, but this is not how current configuration works.L1 is disabled by default. You enable it by configuring the L1 lifespan to be bigger than 0. The attribute definition follows the pattern that Paul did for the server side.My opinion comes probably too late as the PR was already reviewed, discussed and integrated, but at least, please clearly describe the behaviour in the XSD. The fact that l1-lifespan "Defaults to 10 minutes." is not correct - it defaults to L1 being disabled.Yeah, I’ll update the XSD and documentation accordingly: https://issues.jboss.org/browse/ISPN-4195 CheersThanks Radim -- Radim Vansa <rvansa@redhat.com> JBoss DataGrid QA _______________________________________________ infinispan-dev mailing list infinispan-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev-- Galder Zamarreño galder@redhat.com twitter.com/galderz _______________________________________________ infinispan-dev mailing list infinispan-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev