[ https://issues.jboss.org/browse/ISPN-1131?page=com.atlassian.jira.plugin.... ] Mircea Markus updated ISPN-1131: -------------------------------- Complexity: High -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1131?page=com.atlassian.jira.plugin.... ] Mircea Markus edited comment on ISPN-1131 at 5/23/11 4:15 PM: -------------------------------------------------------------- Suggested design. On first release this is an experimental feature disabled by default. In ordert to enable it use the following configuration element: {code:xml} <locking isolationLevel="READ_COMMITTED" lockAtPrepareTime="true" /> {code} In order to preserve the existing functionality and also support *lockAtPrepareTime* a new interceptor is added: {{PrepareTimeLockingInterceptor}}: * it extends {{LockingInterceptor}} * when *lockAtPrepareTime* is enabled it takes {{LockingInterceptor}}'s place is the interceptor chain * it overrides all {{LockingInterceptor}}'s {{visit<WriteCommand>}} methods (e.g. visitpPutKeyValueCommand) and does not acquire write locks on these invocations but read locks * read locks are acquired similar to {{LockingInterceptor.visitGetKeyValueCommand()}}: {code:java} public Object visitGetKeyValueCommand(InvocationContext ctx, GetKeyValueCommand command) throws Throwable { try { entryFactory.wrapEntryForReading(ctx, command.getKey()); return invokeNextInterceptor(ctx, command); } finally { doAfterCall(ctx); } } {code} * {{PrepareTimeLockingInterceptor.visitPrepareCommand}} overrides {{LockingInterceptor.visitPrepareCommand}}: {code:java} @Override public Object visitPrepareCommand(TxInvocationContext ctx, PrepareCommand command) throws Throwable { super.visitPrepareCommand(ctx, command); if (ctx.isOriginLocal()) { for (WriteCommand wc : command.getModifications()) { acquireLock(wc); } } return invokeNextInterceptor(ctx, command); } {code} * {{acquireLock()}} in the code above acquires locks *exactly* the same way {{LockingInterceptor}} would do for a given command. ** E.g. {{acquireLock(PutKeyValueCommand)}} is equivalent with {{LockingInterceptor.visitPutKeyValueCommand(..)}} ** if in distributed mode, the acquire lock *only* acquires a lock if the key(s) within {{WriteCommand}} map to the local node was (Author: mircea.markus): Suggested design. When first released, this will be an experimental feature disabled by default. It will be possible to enable it by using the following configuration element: {code:xml} <locking isolationLevel="READ_COMMITTED" lockAtPrepareTime="true" /> {code} In order to preserve the existing functionality and also support *lockAtPrepareTime* a new interceptor will be added: {{PrepareTimeLockingInterceptor}}: * it extends {{LockingInterceptor}} * when *lockAtPrepareTime* is enabled it takes {{LockingInterceptor}}'s place is the interceptor chain * it overrides the all {{LockingInterceptor}}'s {{visit<WriteCommand>}} methods (e.g. visitpPutKeyValueCommand) and does not acquire write locks on these invocations but read locks * read locks are acquired similar to {{LockingInterceptor.visitGetKeyValueCommand()}}: {code:java} public Object visitGetKeyValueCommand(InvocationContext ctx, GetKeyValueCommand command) throws Throwable { try { entryFactory.wrapEntryForReading(ctx, command.getKey()); return invokeNextInterceptor(ctx, command); } finally { doAfterCall(ctx); } } {code} * {{PrepareTimeLockingInterceptor.visitPrepareCommand}} also overrides the same method from {{LockingInterceptor}}: {code:java} @Override public Object visitPrepareCommand(TxInvocationContext ctx, PrepareCommand command) throws Throwable { super.visitPrepareCommand(ctx, command); if (ctx.isOriginLocal()) { for (WriteCommand wc : command.getModifications()) { acquireLock(wc); } } return invokeNextInterceptor(ctx, command); } {code} * {{acquireLock()}} in the code above acquires locks *exactly* the same way {{LockingInterceptor}} would do for a given command. ** E.g. {{acquireLock(PutKeyValueCommand}} is equivalent with {{LockingInterceptor.visitPutKeyValueCommand(..)}} ** if in distributed mode, the acquire lock *only* acquires a lock if the key(s) within {{WriteCommand}} map to the local node -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1131?page=com.atlassian.jira.plugin.... ] Mircea Markus edited comment on ISPN-1131 at 5/23/11 4:24 PM: -------------------------------------------------------------- Suggested design. On first release this is an experimental feature disabled by default. In ordert to enable it use the following configuration element: {code:xml} <locking isolationLevel="READ_COMMITTED" lockAtPrepareTime="true" /> {code} In order to preserve the existing functionality and also support *lockAtPrepareTime* a new interceptor is added: {{PrepareTimeLockingInterceptor}}: * it extends {{LockingInterceptor}} * when *lockAtPrepareTime* is enabled it takes {{LockingInterceptor}}'s place is the interceptor chain * it overrides all {{LockingInterceptor}}'s {{visit<WriteCommand>}} methods (e.g. visitpPutKeyValueCommand) and does not acquire write locks on these invocations but read locks * read locks are acquired similar to {{LockingInterceptor.visitGetKeyValueCommand()}}: {code:java} public Object visitGetKeyValueCommand(InvocationContext ctx, GetKeyValueCommand command) throws Throwable { try { entryFactory.wrapEntryForReading(ctx, command.getKey()); return invokeNextInterceptor(ctx, command); } finally { doAfterCall(ctx); } } {code} * {{PrepareTimeLockingInterceptor.visitPrepareCommand}} overrides {{LockingInterceptor.visitPrepareCommand}}: {code:java} @Override public Object visitPrepareCommand(TxInvocationContext ctx, PrepareCommand command) throws Throwable { super.visitPrepareCommand(ctx, command); if (ctx.isOriginLocal()) { for (WriteCommand wc : command.getModifications()) { acquireLock(wc); } } return invokeNextInterceptor(ctx, command); } {code} * {{acquireLock()}} in the code above acquires locks *exactly* the same way {{LockingInterceptor}} does for a given command. ** E.g. {{acquireLock(PutKeyValueCommand)}} is equivalent with {{LockingInterceptor.visitPutKeyValueCommand(..)}} ** if in distributed mode, the acquire lock *only* acquires a lock if the key(s) within {{WriteCommand}} map to the local node ** if lock cannot be acquired for a key all acquired locks are release and the transaction is marked for rollback was (Author: mircea.markus): Suggested design. On first release this is an experimental feature disabled by default. In ordert to enable it use the following configuration element: {code:xml} <locking isolationLevel="READ_COMMITTED" lockAtPrepareTime="true" /> {code} In order to preserve the existing functionality and also support *lockAtPrepareTime* a new interceptor is added: {{PrepareTimeLockingInterceptor}}: * it extends {{LockingInterceptor}} * when *lockAtPrepareTime* is enabled it takes {{LockingInterceptor}}'s place is the interceptor chain * it overrides all {{LockingInterceptor}}'s {{visit<WriteCommand>}} methods (e.g. visitpPutKeyValueCommand) and does not acquire write locks on these invocations but read locks * read locks are acquired similar to {{LockingInterceptor.visitGetKeyValueCommand()}}: {code:java} public Object visitGetKeyValueCommand(InvocationContext ctx, GetKeyValueCommand command) throws Throwable { try { entryFactory.wrapEntryForReading(ctx, command.getKey()); return invokeNextInterceptor(ctx, command); } finally { doAfterCall(ctx); } } {code} * {{PrepareTimeLockingInterceptor.visitPrepareCommand}} overrides {{LockingInterceptor.visitPrepareCommand}}: {code:java} @Override public Object visitPrepareCommand(TxInvocationContext ctx, PrepareCommand command) throws Throwable { super.visitPrepareCommand(ctx, command); if (ctx.isOriginLocal()) { for (WriteCommand wc : command.getModifications()) { acquireLock(wc); } } return invokeNextInterceptor(ctx, command); } {code} * {{acquireLock()}} in the code above acquires locks *exactly* the same way {{LockingInterceptor}} would do for a given command. ** E.g. {{acquireLock(PutKeyValueCommand)}} is equivalent with {{LockingInterceptor.visitPutKeyValueCommand(..)}} ** if in distributed mode, the acquire lock *only* acquires a lock if the key(s) within {{WriteCommand}} map to the local node ** if lock cannot be acquired for a key all acquired locks are release and the transaction is marked for rollback -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1131?page=com.atlassian.jira.plugin.... ] Manik Surtani updated ISPN-1131: -------------------------------- Summary: Acquire (write) locks at prepare time even on local node (was: Locking optimization: acquire (write) locks at prepare time) Fix Version/s: 5.1.0.BETA1 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1131?page=com.atlassian.jira.plugin.... ] Mircea Markus edited comment on ISPN-1131 at 6/30/11 9:36 AM: -------------------------------------------------------------- In infinispan 5.1 this will be default locking model, replacing the current one. In order to enable it use the following configuration element: {code:xml} <locking mode="optimistic" isolationLevel="READ_COMMITTED" /> {code} The LockingInterceptor needs to be changed in order not to acquire read locks for writes: {code:java} public Object visitGetKeyValueCommand(InvocationContext ctx, GetKeyValueCommand command) throws Throwable { try { entryFactory.wrapEntryForReading(ctx, command.getKey()); return invokeNextInterceptor(ctx, command); } finally { doAfterCall(ctx); } } {code} Also following logic will be appended to LockingInterceptor.visitPrepareCommand, before invokeNextInterceptor: {code:java} if (ctx.isOriginLocal()) { for (WriteCommand wc : command.getModifications()) { acquireLock(wc); } } {code} acquireLock() in the code above acquires locks exactly the same way LockingInterceptor does for a given command. E.g. acquireLock(PutKeyValueCommand) is equivalent with LockingInterceptor.visitPutKeyValueCommand(..) if in distributed mode, the acquire lock only acquires a lock if the key(s) within WriteCommand map to the local node if lock cannot be acquired for a key all acquired locks are release and the transaction is marked for rollback was (Author: mircea.markus): In infinispan 5.1 this will be default locking model, enabled by default. In order to enable it use the following configuration element: {code:xml} <locking mode="optimistic" isolationLevel="READ_COMMITTED" /> {code} The LockingInterceptor needs to be changed in order not to acquire read locks for writes: {code:java} public Object visitGetKeyValueCommand(InvocationContext ctx, GetKeyValueCommand command) throws Throwable { try { entryFactory.wrapEntryForReading(ctx, command.getKey()); return invokeNextInterceptor(ctx, command); } finally { doAfterCall(ctx); } } {code} Also following logic will be appended to LockingInterceptor.visitPrepareCommand, before invokeNextInterceptor: {code:java} if (ctx.isOriginLocal()) { for (WriteCommand wc : command.getModifications()) { acquireLock(wc); } } {code} acquireLock() in the code above acquires locks exactly the same way LockingInterceptor does for a given command. E.g. acquireLock(PutKeyValueCommand) is equivalent with LockingInterceptor.visitPutKeyValueCommand(..) if in distributed mode, the acquire lock only acquires a lock if the key(s) within WriteCommand map to the local node if lock cannot be acquired for a key all acquired locks are release and the transaction is marked for rollback -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1131?page=com.atlassian.jira.plugin.... ] Mircea Markus updated ISPN-1131: -------------------------------- Description: Detailed here: http://community.jboss.org/wiki/OptimisticLockingInInfinispan was: Detailed here, as the 1st improvement: http://community.jboss.org/wiki/PossibleLockingImprovements -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1131?page=com.atlassian.jira.plugin.... ] Manik Surtani updated ISPN-1131: -------------------------------- Priority: Blocker (was: Major) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1131?page=com.atlassian.jira.plugin.... ] Galder Zamarreño updated ISPN-1131: ----------------------------------- Fix Version/s: 5.1.0.BETA1 (was: 5.1.0.ALPHA2 ) As talked earlier, moving to Beta1. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1131?page=com.atlassian.jira.plugin.... ] Mircea Markus updated ISPN-1131: -------------------------------- Git Pull Request: https://github.com/infinispan/infinispan/pull/551 (was: https://issues.jboss.org/browse/ISPN-1131) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira